Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending #196537

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Oct 16, 2024

Summary

Updated the refresh button to indicate that an update is pending after a query change in Data View and Data Drift.
For: #176737
After:
Data View:

Screen.Recording.2024-10-16.at.13.28.41.mov

Data drift:

Screen.Recording.2024-10-16.at.13.29.56.mov

@rbrtj rbrtj self-assigned this Oct 16, 2024
@rbrtj rbrtj added release_note:enhancement :ml Feature:File and Index Data Viz ML file and index data visualizer v9.0.0 Team:ML Team label for ML (also use :ml) backport:version Backport to applied version labels v8.17.0 labels Oct 16, 2024
@rbrtj rbrtj marked this pull request as ready for review October 16, 2024 11:42
@rbrtj rbrtj requested a review from a team as a code owner October 16, 2024 11:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / Configuration button renders without the tooltip

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 614.0KB 615.3KB +1.3KB

cc @rbrtj

Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rbrtj rbrtj merged commit 33f8fdd into elastic:main Oct 18, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11406662040

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
…ft view to indicate an update is pending (elastic#196537)

## Summary

Updated the refresh button to indicate that an update is pending after a
query change in `Data View` and `Data Drift`.
For: [elastic#176737](elastic#176737)
After:
Data View:

https://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa

Data drift:

https://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea
(cherry picked from commit 33f8fdd)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
…ta Drift view to indicate an update is pending (#196537) (#196915)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data visualizer: Change refresh button in Data View and Data
Drift view to indicate an update is pending
(#196537)](#196537)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T15:34:29Z","message":"[ML]
Data visualizer: Change refresh button in Data View and Data Drift view
to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated
the refresh button to indicate that an update is pending after
a\r\nquery change in `Data View` and `Data Drift`.\r\nFor:
[#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData
View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData
drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File
and Index Data
Viz","v9.0.0","Team:ML","backport:version","v8.17.0"],"title":"[ML] Data
visualizer: Change refresh button in Data View and Data Drift view to
indicate an update is
pending","number":196537,"url":"https://github.com/elastic/kibana/pull/196537","mergeCommit":{"message":"[ML]
Data visualizer: Change refresh button in Data View and Data Drift view
to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated
the refresh button to indicate that an update is pending after
a\r\nquery change in `Data View` and `Data Drift`.\r\nFor:
[#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData
View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData
drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196537","number":196537,"mergeCommit":{"message":"[ML]
Data visualizer: Change refresh button in Data View and Data Drift view
to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated
the refresh button to indicate that an update is pending after
a\r\nquery change in `Data View` and `Data Drift`.\r\nFor:
[#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData
View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData
drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants