-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps: Fixes issue where some queries cause filters to not be applied #196585
[ML] AIOps: Fixes issue where some queries cause filters to not be applied #196585
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested (ML AIOps Labs pages, and dashboard embeddables) and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 🚀 .
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.16, 8.x |
…plied (elastic#196585) (cherry picked from commit 1b6c497)
…plied (elastic#196585) (cherry picked from commit 1b6c497)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… be applied (#196585) (#197513) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)](#196585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T18:05:41Z","message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version","v8.17.0"],"title":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied","number":196585,"url":"https://github.com/elastic/kibana/pull/196585","mergeCommit":{"message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196585","number":196585,"mergeCommit":{"message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
…t be applied (#196585) (#197512) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)](#196585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T18:05:41Z","message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version","v8.17.0"],"title":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied","number":196585,"url":"https://github.com/elastic/kibana/pull/196585","mergeCommit":{"message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196585","number":196585,"mergeCommit":{"message":"[ML] AIOps: Fixes issue where some queries cause filters to not be applied (#196585)","sha":"1b6c497101e1b46d97904538b97faa2e276fa31d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
…197760) ## Summary Follow up to #189863 and #196585. Related to #176387. This updates asserting the url state for log rate analysis with a query and reenables the functional tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
…lastic#197760) ## Summary Follow up to elastic#189863 and elastic#196585. Related to elastic#176387. This updates asserting the url state for log rate analysis with a query and reenables the functional tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 6ef0369)
…lastic#197760) ## Summary Follow up to elastic#189863 and elastic#196585. Related to elastic#176387. This updates asserting the url state for log rate analysis with a query and reenables the functional tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 6ef0369)
…lysis (#197760) (#197795) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)](#197760) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T10:18:24Z","message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version","v8.17.0"],"title":"[ML] AIOps: Fix and reenable functional tests for log rate analysis","number":197760,"url":"https://github.com/elastic/kibana/pull/197760","mergeCommit":{"message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197760","number":197760,"mergeCommit":{"message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
…ysis (#197760) (#197796) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)](#197760) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T10:18:24Z","message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Feature:ML/AIOps","v8.16.0","backport:version","v8.17.0"],"title":"[ML] AIOps: Fix and reenable functional tests for log rate analysis","number":197760,"url":"https://github.com/elastic/kibana/pull/197760","mergeCommit":{"message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197760","number":197760,"mergeCommit":{"message":"[ML] AIOps: Fix and reenable functional tests for log rate analysis (#197760)\n\n## Summary\r\n\r\nFollow up to #189863 and #196585.\r\nRelated to #176387.\r\n\r\nThis updates asserting the url state for log rate analysis with a query\r\nand reenables the functional tests.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"6ef03697460aba0d3774c0c03fb7fb58c76c00bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Replaces the bespoke es query building function
createMergedEsQuery
for the commonly usedbuildEsQuery
shared from@kbn/es-query
.createMergedEsQuery
would usebuildEsQuery
iflucene
is selected as the query bar's language, but it can also be used forKQL
.This change affects all AIOps pages.
Fixes #195212