[Dataset quality] Add missing breakdownField while hydrating the Dataset Quality Details state.
#196798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
awahab07
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
yngrdyn
approved these changes
Oct 18, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
Starting backport for target branches: 8.x |
The property is nullable in state that's why we missed it. Ideally it should be covered by tests but an e2e test for this feels too costly. Perhaps we should invest some time in setting up unit testing wrappers for such components. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…taset Quality Details state. (elastic#196798) Add the missing `breakdownField` while hydrating the context state from public state (e.g. from URL state). (cherry picked from commit f31fa68)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…hydrating the Dataset Quality Details state. (#196798) (#196894) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] Add missing `breakdownField` while hydrating the Dataset Quality Details state. (#196798)](#196798) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T14:18:27Z","message":"[Dataset quality] Add missing `breakdownField` while hydrating the Dataset Quality Details state. (#196798)\n\nAdd the missing `breakdownField` while hydrating the context state from public state (e.g. from URL state).","sha":"f31fa68b801938619b86627d2be3f6be6ade8a6c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset quality] Add missing `breakdownField` while hydrating the Dataset Quality Details state.","number":196798,"url":"https://github.com/elastic/kibana/pull/196798","mergeCommit":{"message":"[Dataset quality] Add missing `breakdownField` while hydrating the Dataset Quality Details state. (#196798)\n\nAdd the missing `breakdownField` while hydrating the context state from public state (e.g. from URL state).","sha":"f31fa68b801938619b86627d2be3f6be6ade8a6c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196798","number":196798,"mergeCommit":{"message":"[Dataset quality] Add missing `breakdownField` while hydrating the Dataset Quality Details state. (#196798)\n\nAdd the missing `breakdownField` while hydrating the context state from public state (e.g. from URL state).","sha":"f31fa68b801938619b86627d2be3f6be6ade8a6c"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196775.
Summary
The PR simply adds the missing
breakdownFieldwhile hydrating the context state from public state (e.g. from URL state).