Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [ci] Extract OAS check + add retry (#196534) #196802

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Oct 18, 2024

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

## Summary
In the past months, the capture OAS snapshot step has been quite flaky,
breaking the `Checks` step, and thus breaking the `on-merge` jobs.

This PR extracts the check to its own step and adds retries. The
separate step is ideal because it is quite heavy compared to the other
checks (we fire up ES + Kibana for the OAS snapshot).

Also, this PR removes the `Checks` step altogether from the
kibana-chrome-forward-testing pipeline, as the Chrome versions used do
not affect that aspect.

This test run includes a retry within the Capture OAS Snapshot step:
https://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea

(cherry picked from commit 2fbc843)

# Conflicts:
#	.buildkite/pipelines/chrome_forward_testing.yml
@delanni delanni enabled auto-merge (squash) October 18, 2024 07:47
@delanni delanni requested a review from a team October 18, 2024 15:26
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / SyncAlertsToggle it renders

Metrics [docs]

✅ unchanged

History

@delanni delanni merged commit 57736ac into elastic:8.16 Oct 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants