[8.x] [Entity Analytics] Bug: update timestamp on criticality soft delete (#196722) #196810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#196722) ## Summary This fixes a bug with asset criticality where "soft delete" does not update the `@timestamp` field (cherry picked from commit 07fc875)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @tiansivive |
hop-dev
added a commit
that referenced
this pull request
Oct 18, 2024
…elete (#196722) (#196881) # Backport This will backport the following commits from `main` to `8.16`: - [[Entity Analytics] Bug: update timestamp on criticality soft delete (#196722)](#196722) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T08:07:32Z","message":"[Entity Analytics] Bug: update timestamp on criticality soft delete (#196722)\n\n## Summary\r\n\r\nThis fixes a bug with asset criticality where \"soft delete\" does not\r\nupdate the `@timestamp` field","sha":"07fc8753604a27b9cc2c7c396e85f9bd9dc40674","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","Team:Entity Analytics","v8.17.0"],"number":196722,"url":"https://github.com/elastic/kibana/pull/196722","mergeCommit":{"message":"[Entity Analytics] Bug: update timestamp on criticality soft delete (#196722)\n\n## Summary\r\n\r\nThis fixes a bug with asset criticality where \"soft delete\" does not\r\nupdate the `@timestamp` field","sha":"07fc8753604a27b9cc2c7c396e85f9bd9dc40674"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196722","number":196722,"mergeCommit":{"message":"[Entity Analytics] Bug: update timestamp on criticality soft delete (#196722)\n\n## Summary\r\n\r\nThis fixes a bug with asset criticality where \"soft delete\" does not\r\nupdate the `@timestamp` field","sha":"07fc8753604a27b9cc2c7c396e85f9bd9dc40674"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196810","number":196810,"state":"MERGED","mergeCommit":{"sha":"7a8f79d4a3c777b10a470dc4e7f458f8b2c7176b","message":"[8.x] [Entity Analytics] Bug: update timestamp on criticality soft delete (#196722) (#196810)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Entity Analytics] Bug: update timestamp on criticality soft delete\n(#196722)](https://github.com/elastic/kibana/pull/196722)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Tiago Vila\nVerde\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T08:07:32Z\",\"message\":\"[Entity\nAnalytics] Bug: update timestamp on criticality soft delete\n(#196722)\\n\\n## Summary\\r\\n\\r\\nThis fixes a bug with asset criticality\nwhere \\\"soft delete\\\" does not\\r\\nupdate the `@timestamp`\nfield\",\"sha\":\"07fc8753604a27b9cc2c7c396e85f9bd9dc40674\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"Team:Entity\nAnalytics\"],\"title\":\"[Entity Analytics] Bug: update timestamp on\ncriticality soft\ndelete\",\"number\":196722,\"url\":\"https://github.com/elastic/kibana/pull/196722\",\"mergeCommit\":{\"message\":\"[Entity\nAnalytics] Bug: update timestamp on criticality soft delete\n(#196722)\\n\\n## Summary\\r\\n\\r\\nThis fixes a bug with asset criticality\nwhere \\\"soft delete\\\" does not\\r\\nupdate the `@timestamp`\nfield\",\"sha\":\"07fc8753604a27b9cc2c7c396e85f9bd9dc40674\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196722\",\"number\":196722,\"mergeCommit\":{\"message\":\"[Entity\nAnalytics] Bug: update timestamp on criticality soft delete\n(#196722)\\n\\n## Summary\\r\\n\\r\\nThis fixes a bug with asset criticality\nwhere \\\"soft delete\\\" does not\\r\\nupdate the `@timestamp`\nfield\",\"sha\":\"07fc8753604a27b9cc2c7c396e85f9bd9dc40674\"}}]}] BACKPORT-->\n\nCo-authored-by: Tiago Vila Verde <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Tiago Vila Verde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation