Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CTA content for web crawler #196853

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented Oct 18, 2024

Summary

Small bug fix for this web crawler CTA button content:
CleanShot 2024-10-18 at 13 31 42@2x
That should say just Crawl URL

@JoseLuisGJ JoseLuisGJ added bug Fixes for quality problems that affect the customer experience v8.16.0 backport v8.15.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development release_note:skip Skip the PR/issue when compiling release notes v8.15.1 backport:version Backport to applied version labels and removed backport labels Oct 18, 2024
@JoseLuisGJ JoseLuisGJ marked this pull request as ready for review October 18, 2024 11:44
@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner October 18, 2024 11:44
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseLuisGJ JoseLuisGJ merged commit 9aaffa9 into elastic:main Oct 18, 2024
44 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11404691172

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
## Summary

Small bug fix for this web crawler CTA button content:
![CleanShot 2024-10-18 at 13 31
42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)
That should say just _Crawl URL_

(cherry picked from commit 9aaffa9)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
## Summary

Small bug fix for this web crawler CTA button content:
![CleanShot 2024-10-18 at 13 31
42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)
That should say just _Crawl URL_

(cherry picked from commit 9aaffa9)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
## Summary

Small bug fix for this web crawler CTA button content:
![CleanShot 2024-10-18 at 13 31
42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)
That should say just _Crawl URL_

(cherry picked from commit 9aaffa9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Fixing CTA content for web crawler
(#196853)](#196853)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T13:30:42Z","message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","v8.15.0","v8.16.0","backport:version"],"title":"Fixing
CTA content for web
crawler","number":196853,"url":"https://github.com/elastic/kibana/pull/196853","mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196853","number":196853,"mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: José Luis González <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 18, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fixing CTA content for web crawler
(#196853)](#196853)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T13:30:42Z","message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","v8.15.0","v8.16.0","backport:version"],"title":"Fixing
CTA content for web
crawler","number":196853,"url":"https://github.com/elastic/kibana/pull/196853","mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196853","number":196853,"mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: José Luis González <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 21, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [Fixing CTA content for web crawler
(#196853)](#196853)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T13:30:42Z","message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","v8.15.0","v8.16.0","backport:version"],"title":"Fixing
CTA content for web
crawler","number":196853,"url":"https://github.com/elastic/kibana/pull/196853","mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196853","number":196853,"mergeCommit":{"message":"Fixing
CTA content for web crawler (#196853)\n\n## Summary\r\n\r\nSmall bug fix
for this web crawler CTA button content:\r\n![CleanShot 2024-10-18 at 13
31\r\n42@2x](https://github.com/user-attachments/assets/edc5f341-30d5-4a90-96bd-3eda2836bbfe)\r\nThat
should say just _Crawl
URL_","sha":"9aaffa9d9114eda8ddca90ae8173d5cbd38ffb95"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: José Luis González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants