fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog #196905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter closing or cancelling Generate API key dialog Closes: elastic#196174
|
/ci |
alexwizp
added
v9.0.0
backport:prev-minor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💚 Build Succeeded
Metrics [docs]Async chunks
|
sphilipse
approved these changes
Oct 21, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…fter closing or cancelling Generate API key dialog (elastic#196905) Closes: elastic#196174 ## Description Focus should be visible on any accessible element and in order when navigating through the elements. Especially for the users using assistive technology, only keyboard. For the dialogs, after closing them, focus should be visible on the element which opened it. ## What was changed: 1. Cleaned up `generate_api_key_panel.tsx`. No need to open `GenerateApiKeyModal` from this level. Same logic duplicated in `APIGettingStarted` inner component ## Screen https://github.com/user-attachments/assets/46a23fdd-ba54-4798-9cb7-a78e28d447b8 (cherry picked from commit 47a497c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…tton after closing or cancelling Generate API key dialog (#196905) (#197069) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog (#196905)](#196905) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T13:59:07Z","message":"fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog (#196905)\n\nCloses: #196174\r\n\r\n## Description \r\n\r\nFocus should be visible on any accessible element and in order when\r\nnavigating through the elements. Especially for the users using\r\nassistive technology, only keyboard.\r\nFor the dialogs, after closing them, focus should be visible on the\r\nelement which opened it.\r\n\r\n## What was changed: \r\n1. Cleaned up `generate_api_key_panel.tsx`. No need to open\r\n`GenerateApiKeyModal` from this level. Same logic duplicated in\r\n`APIGettingStarted` inner component\r\n\r\n## Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/46a23fdd-ba54-4798-9cb7-a78e28d447b8","sha":"47a497cf3671eee56adeb4787cb4c9271671f5e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog","number":196905,"url":"https://github.com/elastic/kibana/pull/196905","mergeCommit":{"message":"fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog (#196905)\n\nCloses: #196174\r\n\r\n## Description \r\n\r\nFocus should be visible on any accessible element and in order when\r\nnavigating through the elements. Especially for the users using\r\nassistive technology, only keyboard.\r\nFor the dialogs, after closing them, focus should be visible on the\r\nelement which opened it.\r\n\r\n## What was changed: \r\n1. Cleaned up `generate_api_key_panel.tsx`. No need to open\r\n`GenerateApiKeyModal` from this level. Same logic duplicated in\r\n`APIGettingStarted` inner component\r\n\r\n## Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/46a23fdd-ba54-4798-9cb7-a78e28d447b8","sha":"47a497cf3671eee56adeb4787cb4c9271671f5e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196905","number":196905,"mergeCommit":{"message":"fix: [Stateful: Indices: Overview page] Missing focus on New button after closing or cancelling Generate API key dialog (#196905)\n\nCloses: #196174\r\n\r\n## Description \r\n\r\nFocus should be visible on any accessible element and in order when\r\nnavigating through the elements. Especially for the users using\r\nassistive technology, only keyboard.\r\nFor the dialogs, after closing them, focus should be visible on the\r\nelement which opened it.\r\n\r\n## What was changed: \r\n1. Cleaned up `generate_api_key_panel.tsx`. No need to open\r\n`GenerateApiKeyModal` from this level. Same logic duplicated in\r\n`APIGettingStarted` inner component\r\n\r\n## Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/46a23fdd-ba54-4798-9cb7-a78e28d447b8","sha":"47a497cf3671eee56adeb4787cb4c9271671f5e8"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #196174
Description
Focus should be visible on any accessible element and in order when navigating through the elements. Especially for the users using assistive technology, only keyboard.
For the dialogs, after closing them, focus should be visible on the element which opened it.
What was changed:
generate_api_key_panel.tsx. No need to openGenerateApiKeyModalfrom this level. Same logic duplicated inAPIGettingStartedinner componentScreen
Screen.Recording.2024-10-18.at.18.02.39.mov