[Automatic Import] Cel template fixes #196945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeller
added
release_note:skip
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
💚 Build Succeeded
Metrics [docs]
cc @kgeller |
bhapas
approved these changes
Oct 19, 2024
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 19, 2024
## Summary This PR corrects the CEL template so that it can successfully complete package policy installation. The fixes are 1) adding a template path, and 2) removing the common template values from the cel templates. Tested and verified with and without the CEL generation FF enabled. (cherry picked from commit 15390e4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Automatic Import] Cel template fixes (#196945)](#196945) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kylie Meli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-19T13:56:55Z","message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","Team:Security-Scalability","backport:version"],"title":"[Automatic Import] Cel template fixes","number":196945,"url":"https://github.com/elastic/kibana/pull/196945","mergeCommit":{"message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196945","number":196945,"mergeCommit":{"message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kylie Meli <[email protected]>
|
@kgeller there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
|
@jbudz It should be, thanks for catching that. I added a label for 8.17 and will make sure it gets backported |
kgeller
added
the
backport:prev-minor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
## Summary This PR corrects the CEL template so that it can successfully complete package policy installation. The fixes are 1) adding a template path, and 2) removing the common template values from the cel templates. Tested and verified with and without the CEL generation FF enabled. (cherry picked from commit 15390e4)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Cel template fixes (#196945)](#196945) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kylie Meli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-19T13:56:55Z","message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.16.0","Team:Security-Scalability","backport:version","v8.17.0"],"title":"[Automatic Import] Cel template fixes","number":196945,"url":"https://github.com/elastic/kibana/pull/196945","mergeCommit":{"message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196945","number":196945,"mergeCommit":{"message":"[Automatic Import] Cel template fixes (#196945)\n\n## Summary\r\n\r\nThis PR corrects the CEL template so that it can successfully complete\r\npackage policy installation. The fixes are 1) adding a template path,\r\nand 2) removing the common template values from the cel templates.\r\n\r\nTested and verified with and without the CEL generation FF enabled.","sha":"15390e4cdb9aecca5ba5782b0081cb244dbd1a08"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196978","number":196978,"state":"MERGED","mergeCommit":{"sha":"b2c151a12f4db817e7aeb2ed7f76fe2217f82c2c","message":"[8.16] [Automatic Import] Cel template fixes (#196945) (#196978)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[Automatic Import] Cel template fixes\n(#196945)](https://github.com/elastic/kibana/pull/196945)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Kylie\nMeli\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-19T13:56:55Z\",\"message\":\"[Automatic\nImport] Cel template fixes (#196945)\\n\\n## Summary\\r\\n\\r\\nThis PR\ncorrects the CEL template so that it can successfully\ncomplete\\r\\npackage policy installation. The fixes are 1) adding a\ntemplate path,\\r\\nand 2) removing the common template values from the\ncel templates.\\r\\n\\r\\nTested and verified with and without the CEL\ngeneration FF\nenabled.\",\"sha\":\"15390e4cdb9aecca5ba5782b0081cb244dbd1a08\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"v8.16.0\",\"Team:Security-Scalability\",\"backport:version\"],\"title\":\"[Automatic\nImport] Cel template\nfixes\",\"number\":196945,\"url\":\"https://github.com/elastic/kibana/pull/196945\",\"mergeCommit\":{\"message\":\"[Automatic\nImport] Cel template fixes (#196945)\\n\\n## Summary\\r\\n\\r\\nThis PR\ncorrects the CEL template so that it can successfully\ncomplete\\r\\npackage policy installation. The fixes are 1) adding a\ntemplate path,\\r\\nand 2) removing the common template values from the\ncel templates.\\r\\n\\r\\nTested and verified with and without the CEL\ngeneration FF\nenabled.\",\"sha\":\"15390e4cdb9aecca5ba5782b0081cb244dbd1a08\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196945\",\"number\":196945,\"mergeCommit\":{\"message\":\"[Automatic\nImport] Cel template fixes (#196945)\\n\\n## Summary\\r\\n\\r\\nThis PR\ncorrects the CEL template so that it can successfully\ncomplete\\r\\npackage policy installation. The fixes are 1) adding a\ntemplate path,\\r\\nand 2) removing the common template values from the\ncel templates.\\r\\n\\r\\nTested and verified with and without the CEL\ngeneration FF\nenabled.\",\"sha\":\"15390e4cdb9aecca5ba5782b0081cb244dbd1a08\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Kylie Meli <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kylie Meli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects the CEL template so that it can successfully complete package policy installation. The fixes are 1) adding a template path, and 2) removing the common template values from the cel templates.
Tested and verified with and without the CEL generation FF enabled.