Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): remove tests migrated to agnostic framework #196949

Closed
wants to merge 7 commits into from
Closed

chore(slo): remove tests migrated to agnostic framework #196949

wants to merge 7 commits into from

Conversation

kdelemme
Copy link
Contributor

Resolves #183397

🌮 Summary

This PR is a follow up of #195927, that removes the old and migrated tests to the agnostic framework.

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team labels Oct 18, 2024
@kdelemme kdelemme marked this pull request as ready for review October 21, 2024 14:58
@kdelemme kdelemme requested review from a team as code owners October 21, 2024 14:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

dmlemeshko
dmlemeshko approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appex-qa changes LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

dominiqueclarke
dominiqueclarke approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme
Copy link
Contributor Author

Deleted too many things in this PR, starting fresh on #197711

@kdelemme kdelemme closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@jcger jcger jcger approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate SLO API tests to deployment agnostic solution
6 participants
@kdelemme @elasticmachine @dmlemeshko @dominiqueclarke @jcger @kibanamachine