Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [APM][Otel]Fix get_error_group_main_statistics making trace.id optional field (#196822) #196967

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…al field (elastic#196822)

fixes [196821](elastic#196821)

## Summary

`trace.id` should've been sent as an optional field to the
`get_error_group_main_statistics` query. This PR fixes that

<img width="700" alt="image"
src="https://github.com/user-attachments/assets/20b63361-9645-418f-a611-2c0e29b385c7">

## How to test

- Run the opentelemetry demo:
https://github.com/elastic/opentelemetry-demo/tree/rca_ingress_obs
- Navigate to Application > Services
- Open the service details for loadgenerator

(cherry picked from commit a36fa11)
@kibanamachine kibanamachine requested a review from a team as a code owner October 18, 2024 23:21
@kibanamachine kibanamachine enabled auto-merge (squash) October 18, 2024 23:21
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos
Copy link
Contributor

@elasticmachine merge upstream

@crespocarlos
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 21, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: a9ce0eb
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196967-a9ce0ebd6dfa

Metrics [docs]

✅ unchanged

History

cc @crespocarlos

@kibanamachine kibanamachine merged commit 31123df into elastic:8.x Oct 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants