-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove square brackets in FROM METADATA declaration #196991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanx a lot for the contribution. I have added some comments which need to be addressed.
When you do the changes run again the validation.test.ts to update the packages/kbn-esql-validation-autocomplete/src/validation/esql_validation_meta_tests.json
file.
...bn-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.from.test.ts
Show resolved
Hide resolved
...bn-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.from.test.ts
Show resolved
Hide resolved
...bn-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.from.test.ts
Show resolved
Hide resolved
packages/kbn-esql-validation-autocomplete/src/definitions/options.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/kibana-esql (Team:ESQL) |
Hi @stratoula, thanks so much for your feedback! I’ll make sure to implement the changes according to your suggestions. I really appreciate your patience! |
/ci |
@kyracho really appreciate it. Can you take care of the unit tests failures too? When done ping me to rerun the CI 🙌 |
Hi, I noticed I don’t have access to view the Buildkite logs on this PR, which is making it difficult to troubleshoot the failures independently. Could I be granted access to the Buildkite logs to streamline the process, or could someone share the relevant logs for the test failures? Thanks so much for the help! |
@stratoula thanks for your response! I tried running the specific Jest test locally using I also looked for a way to run all Jest tests in the codebase but couldn’t find a command for that. Could you tell me how to run the full suite, or if there's a specific way to narrow down the tests? |
Try this
|
I was able to reproduce the Jest test failures — thank you! :) For the |
This sees unrelated with your changes so I assume it is just a flaky test, lets fix the unit tests and rerun the CI to see if they will fail again |
@stratoula thanks for your help! I adjusted Thanks for being patient as I'm learning a lot as I go! |
Awesome @kyracho, we appreciate the help! Let me re-run the CI 🤞 |
/ci |
@nkhristinin can you take a look on these cypress tests failing here? They seem irrelevant with the change and they are just flaky. Can you confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES|QL changes LGTM, thanx for clearing this up and for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in Data Discovery tests LGTM 👍
@elasticmachine run docs-build |
@stratoula TYSM! <3 |
/ci |
I have confirmed that the test failing is irrelevant, I will re-run the CI and merge |
@elasticmachine run docs-build |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Summary
Hello, this PR addresses the deprecation of square brackets in FROM METADATA declarations in Elasticsearch queries, in preparation for Elasticsearch 9.0. Closes #196988
The changes involve removing square brackets around metadata fields (e.g.,
[metadata _id]
becomesmetadata _id
) across various parts of the codebase. No functional changes to the UE, only internal query syntax updates.Checklist
For maintainers