Remove square brackets in FROM METADATA declaration

[kyracho]

Summary

Hello, this PR addresses the deprecation of square brackets in FROM METADATA declarations in Elasticsearch queries, in preparation for Elasticsearch 9.0. Closes #196988

The changes involve removing square brackets around metadata fields (e.g., [metadata _id] becomes metadata _id) across various parts of the codebase. No functional changes to the UE, only internal query syntax updates.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This will appear in the Release Notes and follow the guidelines

[stratoula]

Hey, thanx a lot for the contribution. I have added some comments which need to be addressed.

When you do the changes run again the validation.test.ts to update the packages/kbn-esql-validation-autocomplete/src/validation/esql_validation_meta_tests.json file.

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[kyracho]

Hey, thanx a lot for the contribution. I have added some comments which need to be addressed.

Hi @stratoula, thanks so much for your feedback! I’ll make sure to implement the changes according to your suggestions. I really appreciate your patience!

[stratoula]

/ci

[stratoula]

@kyracho really appreciate it. Can you take care of the unit tests failures too? When done ping me to rerun the CI 🙌

[kyracho]

Hi, I noticed I don’t have access to view the Buildkite logs on this PR, which is making it difficult to troubleshoot the failures independently. Could I be granted access to the Buildkite logs to streamline the process, or could someone share the relevant logs for the test failures? Thanks so much for the help!

[stratoula]

U r right, I cant grant you access to the buildkite but here they are

If you ran the validation.test.ts file I told you above you will see them

[kyracho]

@stratoula thanks for your response! I tried running the specific Jest test locally using
yarn test:jest packages/kbn-esql-validation-autocomplete/src/validation/validation.test.ts
and it passes without issues:

I also looked for a way to run all Jest tests in the codebase but couldn’t find a command for that. Could you tell me how to run the full suite, or if there's a specific way to narrow down the tests?

[stratoula]

Try this

node scripts/jest --config packages/kbn-esql-validation-autocomplete/jest.config.js packages/kbn-esql-validation-autocomplete/src/validation

[kyracho]

Try this

node scripts/jest --config packages/kbn-esql-validation-autocomplete/jest.config.js packages/kbn-esql-validation-autocomplete/src/validation

I was able to reproduce the Jest test failures — thank you! :) For the FTR Configs #33 error, could you point me to the specific test or config I should run to replicate it locally? Thanks in advance!

[stratoula]

This sees unrelated with your changes so I assume it is just a flaky test, lets fix the unit tests and rerun the CI to see if they will fail again

[kyracho]

@stratoula thanks for your help!

I adjusted validation.command.from.ts and validation.ccs.test.ts to pass the unit tests:

Thanks for being patient as I'm learning a lot as I go!

[stratoula]

Awesome @kyracho, we appreciate the help! Let me re-run the CI 🤞

[stratoula]

/ci

[stratoula]

@nkhristinin can you take a look on these cypress tests failing here? They seem irrelevant with the change and they are just flaky. Can you confirm?

[stratoula]

ES|QL changes LGTM, thanx for clearing this up and for your contribution!

[jughosta]

Changes in Data Discovery tests LGTM 👍

[stratoula]

@elasticmachine run docs-build

[kyracho]

@stratoula TYSM! <3

[stratoula]

/ci

[stratoula]

I have confirmed that the test failing is irrelevant, I will re-run the CI and merge

[stratoula]

@elasticmachine run docs-build

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: c182612

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
esql	180.5KB	180.4KB	-126.0B
unifiedSearch	353.2KB	353.1KB	-126.0B
total			-252.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-srcJs	3.4MB	3.4MB	-119.0B

History

• 💔 Build #247045 failed ad3de06
• 💔 Build #246533 failed 92cf372