Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Engine] fixes preview logs issue when switching between rules #197098

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Oct 21, 2024

@vitaliidm vitaliidm self-assigned this Oct 21, 2024
@vitaliidm vitaliidm added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 21, 2024
@vitaliidm vitaliidm marked this pull request as ready for review October 23, 2024 08:58
@vitaliidm vitaliidm requested a review from a team as a code owner October 23, 2024 08:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@elastic elastic deleted a comment from elasticmachine Oct 23, 2024
@vitaliidm vitaliidm added the backport:version Backport to applied version labels label Oct 23, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB +12.0B

cc @vitaliidm

Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitaliidm vitaliidm merged commit 6a6d1f3 into elastic:main Oct 28, 2024
47 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11558479493

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2024
…witching between rules (elastic#197098)

## Summary

 - addresses elastic#196616

(cherry picked from commit 6a6d1f3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2024
…witching between rules (elastic#197098)

## Summary

 - addresses elastic#196616

(cherry picked from commit 6a6d1f3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 28, 2024
… when switching between rules (#197098) (#198050)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Detection Engine] fixes preview logs issue when
switching between rules
(#197098)](#197098)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-28T16:35:36Z","message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Detection
Engine","v8.16.0","backport:version","v8.17.0"],"title":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between
rules","number":197098,"url":"https://github.com/elastic/kibana/pull/197098","mergeCommit":{"message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197098","number":197098,"mergeCommit":{"message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 28, 2024
…when switching between rules (#197098) (#198051)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Detection Engine] fixes preview logs issue when
switching between rules
(#197098)](#197098)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-28T16:35:36Z","message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Detection
Engine","v8.16.0","backport:version","v8.17.0"],"title":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between
rules","number":197098,"url":"https://github.com/elastic/kibana/pull/197098","mergeCommit":{"message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197098","number":197098,"mergeCommit":{"message":"[Security
Solution][Detection Engine] fixes preview logs issue when switching
between rules (#197098)\n\n## Summary\r\n\r\n - addresses
https://github.com/elastic/kibana/issues/196616","sha":"6a6d1f3b6e41f8e1740d3bba4f5537feddbbbb24"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <[email protected]>
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants