-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Add searchSourceStart.create error handling #197238
[Reporting] Add searchSourceStart.create error handling #197238
Conversation
Pinging @elastic/appex-sharedux (Team:SharedUX) |
const reportingError = new ReportingSavedObjectNotFoundError(err); | ||
throw createTaskRunError(reportingError, TaskErrorSource.USER); | ||
} | ||
throw new Error(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be
throw new Error(err); | |
throw err; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. That's right. I'll change this 👍🏻
…//github.com/kowalczyk-krzysztof/kibana into feat/searchsourcestart-create-error-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Page load bundle
|
Summary
This PR adds a new type of error (
ReportingSavedObjectNotFoundError
) which gets thrown when passed in saved object doesn't exist.This produces a log like this:
Closes: #191548
Closes: #196620