Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [TopNav] Ability for menu items to collapse into popover at custom breakpoints (#195820) #197269

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[8.x] [TopNav] Ability for menu items to collapse into popover at custom breakpoints (#195820) #197269

merged 1 commit into from
Oct 22, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@tsullivan
[TopNav] Ability for menu items to collapse into popover at custom br…
01e1fbd 
…eakpoints (elastic#195820)

## Summary

Closes elastic#154414

Allows customization of `popoverBreakpoints` that are passed to
`EuiHeaderLinks`. See
https://eui.elastic.co/#/layout/header#header-links

BEFORE

![before-bldx7lhzrxkzrxkyzr](https://github.com/user-attachments/assets/798836b1-f254-4f11-bda4-803caf0e02e5)

AFTER

![after-bldx7lhzrxkzrxkyzr](https://github.com/user-attachments/assets/c227746b-00b0-4a41-9982-00b7cfb7e084)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit a5e49e6)
@kibanamachine kibanamachine requested a review from a team as a code owner October 22, 2024 15:09
@kibanamachine kibanamachine requested a review from a team as a code owner October 22, 2024 15:09
@kibanamachine kibanamachine enabled auto-merge (squash) October 22, 2024 15:09
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2024
Merged
2 tasks
@kibanamachine kibanamachine merged commit 259ab11 into elastic:8.x Oct 22, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
navigation 55 53 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
navigation 17.3KB 17.4KB +82.0B
Unknown metric groups

API count

id before after diff
navigation 57 55 -2

cc @tsullivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@tsullivan tsullivan

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @tsullivan