-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine][FTRs] Break down long running FTR groups and fix threshold preview bug #197368
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7258[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/exceptions/operators_data_types/date_types/basic_license_essentials_tier/configs/ess.config.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7269[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/exceptions/operators_data_types/integer/basic_license_essentials_tier/configs/ess.config.ts: 25/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7268[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/configs/ess.config.ts: 10/10 tests passed. |
This comment was marked as outdated.
This comment was marked as outdated.
…iew fails when trying to rebuild history using preview alerts index - thanks marshall for helping fix
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7299[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/threshold/trial_license_complete_tier/configs/ess.config.ts: 25/25 tests passed. |
💚 Build Succeeded
Metrics [docs]
cc @yctercero |
@@ -46,6 +46,9 @@ export const getThresholdSignalHistory = async ({ | |||
const response = await esClient.search({ | |||
...request, | |||
index: indexPattern, | |||
// If alerts index is not yet created, | |||
// do not throw a 404 | |||
ignore_unavailable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Starting backport for target branches: 8.x |
…hreshold preview bug (elastic#197368) ## Summary This PR breaks down long running FTR groups into smaller chunks that now run in <~15 min. - Addresses elastic#192109 - There is no existing ticket but rule_execution group tests are taking ~55m to run and will soon be a bottle neck for us. - No edits made to any existing tests. - Purely just a reshuffle of the tests. See elastic#198209 for details on bug. (cherry picked from commit cd1fafe)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
This PR breaks down long running FTR groups into smaller chunks that now run in <~15 min.
exception_operators_date_numeric_types:essentials:qa:serverless:release
tests optimization #192109Flakey test runner does not run MKI environment. I ran that manually on my local.
Important
When isolating the tests into different groups, found a bug where running rule preview on a Threshold rule prior
to the
.preview-alerts
index being created fails. Because there is no execution history, threshold rule attemptsto recreate it by searching alerts index (which is not yet created). Spoke with @marshallmain who pointed me to
the offending code and suggested a fix of adding
ignore_unavailable
.See #198209 for details on bug.
Running flakey test runner after fix should see all pass.