Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] File upload: enabling check for model allocations #197395

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 23, 2024

Enables the previously commented out check for num_allocations when listing the inference endpoints.

The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed.

Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095

Follow on from #196577

@jgowdyelastic jgowdyelastic self-assigned this Oct 23, 2024
@jgowdyelastic jgowdyelastic added release_note:enhancement non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Feature:File and Index Data Viz ML file and index data visualizer Feature:File Upload v8.16.0 backport:version Backport to applied version labels v8.17.0 and removed non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Oct 23, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review October 23, 2024 09:56
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 23, 2024 09:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @jgowdyelastic

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 66b2447 into main Oct 24, 2024
22 checks passed
@jgowdyelastic jgowdyelastic deleted the enabling-check-for-model-allocations branch October 24, 2024 15:33
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11502602458

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
Enables the previously commented out check for `num_allocations` when
listing the inference endpoints.

The adaptive allocation count can drop to 0, but it is still valid for
use. Uploading a file will cause it to be re-deployed.

Related to es PRs elastic/elasticsearch#115233
and elastic/elasticsearch#115095

Follow on from elastic#196577

(cherry picked from commit 66b2447)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
Enables the previously commented out check for `num_allocations` when
listing the inference endpoints.

The adaptive allocation count can drop to 0, but it is still valid for
use. Uploading a file will cause it to be re-deployed.

Related to es PRs elastic/elasticsearch#115233
and elastic/elasticsearch#115095

Follow on from elastic#196577

(cherry picked from commit 66b2447)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
… (#197677)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] File upload: enabling check for model allocations
(#197395)](#197395)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T15:33:36Z","message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File
and Index Data Viz","Feature:File
Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
File upload: enabling check for model
allocations","number":197395,"url":"https://github.com/elastic/kibana/pull/197395","mergeCommit":{"message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197395","number":197395,"mergeCommit":{"message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
#197678)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] File upload: enabling check for model allocations
(#197395)](#197395)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T15:33:36Z","message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File
and Index Data Viz","Feature:File
Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
File upload: enabling check for model
allocations","number":197395,"url":"https://github.com/elastic/kibana/pull/197395","mergeCommit":{"message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197395","number":197395,"mergeCommit":{"message":"[ML]
File upload: enabling check for model allocations (#197395)\n\nEnables
the previously commented out check for `num_allocations` when\r\nlisting
the inference endpoints.\r\n\r\nThe adaptive allocation count can drop
to 0, but it is still valid for\r\nuse. Uploading a file will cause it
to be re-deployed.\r\n\r\nRelated to es PRs
https://github.com/elastic/elasticsearch/pull/115233\r\nand
https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nFollow on
from
https://github.com/elastic/kibana/pull/196577","sha":"66b2447fe7879dec1ede5c5cd3aea9b34ae1fad9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants