Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution][Documents Flyout] Fix analyzer preview copy (#197348) #197519

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…tic#197348)

## Summary

This PR fixed a small copy bug related to the visualizations in flyout
feature. When analyzer preview is open, the header and footer should
reflect whether the document is an alert or event.

Prerequisite: enable advanced setting `enableVisualizationsInFlyout`

![image](https://github.com/user-attachments/assets/795fa383-2de3-468d-a962-cd20bdf5da13)

![image](https://github.com/user-attachments/assets/30b87a52-1a18-4d7c-aab8-edb273faf7f2)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 4df5b5a)
@kibanamachine kibanamachine merged commit d5b7cc0 into elastic:8.16 Oct 23, 2024
38 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.1MB 21.1MB +416.0B

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants