Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Share] Cleanup share model UI and warning logic (#196401) #197532

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

cleanup share modal UI with better context around warnings and styles

(cherry picked from commit 67de924)
@kibanamachine kibanamachine merged commit 9a0500d into elastic:8.x Oct 23, 2024
23 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
share 72 73 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 51.5KB 51.4KB -146.0B
reporting 53.3KB 52.7KB -596.0B
share 57.2KB 57.6KB +416.0B
total -326.0B
Unknown metric groups

API count

id before after diff
share 135 136 +1

cc @nickofthyme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants