Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] fix multiline comment syntax highlighting #197545

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Oct 23, 2024

Summary

Highlighting bug fix

Close #197250

Screenshot 2024-10-23 at 5 24 29 PM

Other stuff

This PR also moves tokenizer logic to kbn-esql-ast package, abstracting it from Monaco. Monaco will still drive the tokenizer requirements, but there are a couple of benefits to this change.

  1. Cleaner code. Separating it from Monaco constructs simplifies the core logic and increases understandability.
  2. It may make sense to divorce the tokenizer from Kibana eventually along with the other highly-ANTLR-coupled stuff. I could see it powering syntax highlighting in EUI for example (Add ES|QL syntax highlighting to `EuiCodeBlock` and `EuiMarkdown` components eui#8046), and certainly in IDEs.

Checklist

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] Multi-line Comments is not colored correctly
2 participants