[Search] Fix autogenerated connector names #197585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
added
bug
navarone-feekery
added
the
release_note:skip
navarone-feekery
changed the title
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
LGTM 👍 |
JoseLuisGJ
approved these changes
Oct 25, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Improve the autogenerated connector names by - Re-generating names when changing connector source - Preventing editing of names after connector is created (cherry picked from commit c05e1c5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Improve the autogenerated connector names by - Re-generating names when changing connector source - Preventing editing of names after connector is created (cherry picked from commit c05e1c5)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Search] Fix autogenerated connector names (#197585)](#197585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T07:53:16Z","message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Search] Fix autogenerated connector names","number":197585,"url":"https://github.com/elastic/kibana/pull/197585","mergeCommit":{"message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197585","number":197585,"mergeCommit":{"message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Search] Fix autogenerated connector names (#197585)](#197585) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Navarone Feekery","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T07:53:16Z","message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Search","backport:prev-major","v8.16.0","v8.17.0"],"title":"[Search] Fix autogenerated connector names","number":197585,"url":"https://github.com/elastic/kibana/pull/197585","mergeCommit":{"message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197585","number":197585,"mergeCommit":{"message":"[Search] Fix autogenerated connector names (#197585)\n\nImprove the autogenerated connector names by\r\n\r\n- Re-generating names when changing connector source\r\n- Preventing editing of names after connector is created","sha":"c05e1c58ab7677bf082dc11da040a0c3be4d6498"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Navarone Feekery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the autogenerated connector names by
There is one caveat; if a user manually enters a connector name then changes the source, the name will be replaced by an autogenerated one. I think this is acceptable because users shouldn't be frequently changing the source during the creation flow anyway. To fix this will require some refactoring and I don't think we want to get into that right now.