Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Overview] Improve analyzer by filtering unsuitable tokens #197868

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

weltenwort
Copy link
Member

📝 Summary

This improves the analyzer configuration used by the logs overview categorization feature so it's less susceptible to numeric and hexadecimal values that overwhelm the rest of the content after tokentization.

closes #197255

🎨 Previews

before
Pasted image 20241025180228

after
Pasted image 20241025180131

🕵️‍♀️ Review notes

For testing the synthtrace scenario distributed_unstructured_logs can be used to create test data:

node scripts/synthtrace.js \
  --from=now-12h \
  --to=now+12h \
  --logLevel=debug \
  distributed_unstructured_logs.ts \
  --scenarioOpts.distribution=poisson \
  --scenarioOpts.rate=10000 \
  --scenarioOpts.messageGroup=userAuthentication

@weltenwort weltenwort added release_note:enhancement backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-logs Observability Logs User Experience Team labels Oct 25, 2024
@weltenwort weltenwort self-assigned this Oct 25, 2024
@weltenwort weltenwort requested review from a team as code owners October 25, 2024 16:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 28, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 3fee0a8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197868-3fee0a8cb5b8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logsShared 424.1KB 424.3KB +233.0B

History

cc @weltenwort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:enhancement Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs Overview] Filter unsuitable tokens
3 participants