Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip _esql_view.ts #197947

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[Discover] Unskip _esql_view.ts #197947

merged 1 commit into from
Oct 28, 2024

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 28, 2024 •
edited
Loading

Summary

Fixes #196866

It seems it just temporarily failed, high likely was fixed in a follow up commit

Checklist

@kertal kertal self-assigned this Oct 28, 2024
@kertal
Copy link
Member Author

kertal commented Oct 28, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @kertal

@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) backport:skip This commit does not require backporting labels Oct 28, 2024
@kertal kertal marked this pull request as ready for review October 28, 2024 10:02
@kertal kertal requested a review from a team as a code owner October 28, 2024 10:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added backport:version Backport to applied version labels v8.16.0 and removed backport:skip This commit does not require backporting labels Oct 28, 2024
jughosta
jughosta approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Oct 28, 2024
@kertal kertal merged commit 16cd659 into 8.x Oct 28, 2024
35 checks passed
@kertal kertal deleted the kertal-patch-2 branch October 28, 2024 15:03
@kertal kertal changed the title Unskip _esql_view.ts [Discover] Unskip _esql_view.ts Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees

@kertal kertal

Labels
backport:version Backport to applied version labels Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kertal @elasticmachine @jughosta