[Search] Fix playground crash when adding connector #198365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
TattdCodeMonkey
approved these changes
Oct 30, 2024
|
Starting backport for target branches: 8.16, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
Fixes an issue where Playground occasionally crashed because a connector model is undefined. (cherry picked from commit ac31935)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
Fixes an issue where Playground occasionally crashed because a connector model is undefined. (cherry picked from commit ac31935)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…198399) # Backport This will backport the following commits from `main` to `8.16`: - [[Search] Fix playground crash when adding connector (#198365)](#198365) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:12:16Z","message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"[Search] Fix playground crash when adding connector","number":198365,"url":"https://github.com/elastic/kibana/pull/198365","mergeCommit":{"message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198365","number":198365,"mergeCommit":{"message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…198400) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] Fix playground crash when adding connector (#198365)](#198365) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:12:16Z","message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"[Search] Fix playground crash when adding connector","number":198365,"url":"https://github.com/elastic/kibana/pull/198365","mergeCommit":{"message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198365","number":198365,"mergeCommit":{"message":"[Search] Fix playground crash when adding connector (#198365)\n\nFixes an issue where Playground occasionally crashed because a connector\r\nmodel is undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Playground occasionally crashed because a connector model is undefined.