Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Fix playground crash when adding connector #198365

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Oct 30, 2024

Fixes an issue where Playground occasionally crashed because a connector model is undefined.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.17.0 labels Oct 30, 2024
@sphilipse sphilipse requested a review from a team as a code owner October 30, 2024 14:30
@sphilipse sphilipse added Team:Search backport:version Backport to applied version labels labels Oct 30, 2024
@sphilipse sphilipse enabled auto-merge (squash) October 30, 2024 14:32
@sphilipse sphilipse merged commit ac31935 into elastic:main Oct 30, 2024
33 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11597242668

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchPlayground 167.0KB 167.1KB +45.0B

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
Fixes an issue where Playground occasionally crashed because a connector
model is undefined.

(cherry picked from commit ac31935)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
Fixes an issue where Playground occasionally crashed because a connector
model is undefined.

(cherry picked from commit ac31935)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 30, 2024
…198399)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Search] Fix playground crash when adding connector
(#198365)](#198365)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:12:16Z","message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"[Search]
Fix playground crash when adding
connector","number":198365,"url":"https://github.com/elastic/kibana/pull/198365","mergeCommit":{"message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198365","number":198365,"mergeCommit":{"message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…198400)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] Fix playground crash when adding connector
(#198365)](#198365)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:12:16Z","message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"[Search]
Fix playground crash when adding
connector","number":198365,"url":"https://github.com/elastic/kibana/pull/198365","mergeCommit":{"message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198365","number":198365,"mergeCommit":{"message":"[Search]
Fix playground crash when adding connector (#198365)\n\nFixes an issue
where Playground occasionally crashed because a connector\r\nmodel is
undefined.","sha":"ac3193582edba82a9791e483b143de33ed50f47b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants