Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Explorer] Fix privilege checks bug #198368

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Logs Explorer] Fix privilege checks bug #198368

wants to merge 11 commits into from
+65 −39

Conversation

mohamedhamed-ahmed
Copy link
Contributor

Summary

This PR enhances the privilege checks for Logs Explorer side nav visibility.

@mohamedhamed-ahmed mohamedhamed-ahmed added backport:skip This commit does not require backporting Team:obs-ux-logs Observability Logs User Experience Team labels Oct 30, 2024
weltenwort
weltenwort approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of our future selves, thanks for making it more robust! ❤️

I left some suggestions for simplifying further below. And I wonder what you think about the use of Accessibility and accessible in the variable names. Could those cause confusion with the (a11y) accessibility of the UI?

x-pack/plugins/observability_solution/infra/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/infra/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/infra/public/plugin.ts Outdated Show resolved Hide resolved
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review October 31, 2024 10:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed added the release_note:skip Skip the PR/issue when compiling release notes label Oct 31, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 31, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: b51d612
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198368-b51d612ec36a

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 56.2KB 56.3KB +87.0B

History

cauemarcondes
cauemarcondes approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedhamed-ahmed @elasticmachine @weltenwort @cauemarcondes