Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix styling issues for visualizations #198410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SecuritySolution] Fix styling issues for visualizations #198410

wants to merge 2 commits into from
+12 −17

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Oct 30, 2024 •
edited
Loading

Summary

Fixes: #198370

Before - The was an unexpected outline for each visualization.

Screenshot 2024-10-30 at 14 50 08

After - Overriding the style to avoid unexpected styling changed.

Screenshot 2024-10-30 at 17 28 38
Screen.Recording.2024-10-30.at.18.26.32.mov

@angorayc angorayc changed the title Remove border for visualizations [SecuritySolution] Fix styling issues for visualizations Oct 30, 2024
@angorayc angorayc marked this pull request as ready for review October 30, 2024 18:43
@angorayc angorayc requested a review from a team as a code owner October 30, 2024 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / useSuggestUserProfiles shows a toast error message when an error occurs in the response

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.0MB 21.0MB -255.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum Awaiting requested review from machadoum

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport Team:Threat Hunting:Explore v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SecuritySolution] Unexpected outline around visualizations
2 participants
@angorayc @elasticmachine