Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Stateful sidenav] Update feedback urls (#198143) #198480

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[8.x] [Stateful sidenav] Update feedback urls (#198143) #198480

merged 1 commit into from
Oct 31, 2024

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Oct 31, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@sebelga
[Stateful sidenav] Update feedback urls (elastic#198143)
89af80c 
(cherry picked from commit 89fe548)

# Conflicts:
#	x-pack/plugins/spaces/tsconfig.json
@sebelga sebelga enabled auto-merge (squash) October 31, 2024 09:19
@sebelga sebelga mentioned this pull request Oct 31, 2024
Merged
@sebelga sebelga merged commit 44df1bb into elastic:8.x Oct 31, 2024
28 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / Description renders description correctly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-chrome-browser 103 104 +1
cloud 21 20 -1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 25.6KB 25.8KB +150.0B
serverless 26.3KB 26.5KB +151.0B
total +301.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 452.1KB 452.1KB +9.0B
navigation 17.8KB 17.9KB +15.0B
serverlessSearch 21.5KB 21.5KB -4.0B
total +20.0B
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-browser 210 211 +1
cloud 84 83 -1
total -0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebelga @elasticmachine @Dosant