Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant: some clean-up #209545

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant: some clean-up #209545

wants to merge 2 commits into from
+22 −12

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Feb 4, 2025 •
edited
Loading

Addresses: #193184
Is a follow-up to: #207091, #208090, #207906

Summary

This PR follows after our recent changes made to the Upgrade Assistant and does some minor cleanup:

  • The doc link is renamed to legacyRuleManagementBulkApiDeprecations for the sake of being more specific.
  • The deprecation level is changed to warning in accordance to what we have in 8.x and 8.18.

@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Feb 4, 2025
@banderror banderror requested a review from nikitaindik February 4, 2025 13:39
@banderror banderror self-assigned this Feb 4, 2025
@banderror banderror requested review from a team as code owners February 4, 2025 13:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik
Copy link
Contributor

@banderror Do you believe we need these changes since the severity is already set as "warning" in 8.18 and 8.x, and endpoints are not accessible beyond these versions anyways.

@banderror banderror mentioned this pull request Feb 4, 2025
Closed
@nikitaindik
Copy link
Contributor

PR that set "warning" in 8.18 and 8.x

nastasha-solomon
nastasha-solomon approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

@banderror
Copy link
Contributor Author

banderror commented Feb 4, 2025 •
edited
Loading

Do you believe we need these changes since the severity is already set as "warning" in 8.18 and 8.x, and endpoints are not accessible beyond these versions anyways.

@nikitaindik I just didn't understand why do we have to have different severity levels in different branches. Let's keep it simple?

@banderror banderror force-pushed the adjust-doclinks-rules-bulk-crud-api-endpoints branch from 4180d1c to 8aa836d Compare February 5, 2025 13:06
@banderror
Copy link
Contributor Author

@nikitaindik Do you approve or planning to continue reviewing it?

@nikitaindik
Copy link
Contributor

@banderror I'll review it a bit later today. Will notify you once done.

@banderror banderror force-pushed the adjust-doclinks-rules-bulk-crud-api-endpoints branch from 8aa836d to 35f2066 Compare February 10, 2025 12:45
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #48 / maps app geo file upload shapefile upload should add as document layer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.8KB 93.8KB +14.0B
lists 143.3KB 143.3KB +14.0B
total +28.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 484.8KB 484.8KB +14.0B

cc @banderror

@banderror banderror requested a review from dplumlee February 11, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@nikitaindik nikitaindik Awaiting requested review from nikitaindik

@dplumlee dplumlee Awaiting requested review from dplumlee

At least 1 approving review is required to merge this pull request.

Assignees

@banderror banderror

Labels
backport:version Backport to applied version labels Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@banderror @elasticmachine @nikitaindik @nastasha-solomon