-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic Import] Fixes the CSV header bug #212513
Merged
ilyannn
merged 9 commits into
elastic:main
from
ilyannn:auto-import/fix/csv-mapping-timestamp-bug
Feb 28, 2025
Merged
[Automatic Import] Fixes the CSV header bug #212513
ilyannn
merged 9 commits into
elastic:main
from
ilyannn:auto-import/fix/csv-mapping-timestamp-bug
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:ilyannn/kibana into auto-import/fix/csv-mapping-timestamp-bug
💔 Build Failed
Failed CI StepsHistorycc @ilyannn |
P1llus
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good one
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-major
Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development
release_note:fix
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
Automatic Import now produces correct pipeline to parse CSV files with special characters in column names.
Summary
Fixes #211911
Now the pipeline works as expected:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesDetails
The CSV processing is now a three-stage process:
column1
.package.dataStream.columnName
.{"columnName": "value", ...}
for further processing.Tests
There are unit tests tests for the CSV functionality that include a mock CSV processing pipeline.