[Reporting/New Platform] Provide async access to server-side dependencies #56824

tsullivan · 2020-02-05T05:33:29Z

Summary

Migrates the Reporting plugin server-side to access these dependences outside of the context of a request:

savedObjectsClient
uiSettingsService

Since these dependences are available in the start method of the new ReportingPlugin class, I have moved some setup code to start:

esqueue
enqueueJobFn

Previous init functionality is still run in the setup method, such as validating the configuration (and setting default encryption key) and setting the routes.

In this PR, the ReportingPlugin class provides async getters for all of these dependencies. The reporting object is now passed to route registration and is now part of the export type definitions. This is a new facade utilized by a large part of the Reporting server-side code, which amounts to a lot of lines of code change in this PR.

Checklist

Delete any items that are not applicable to this PR.

~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] This was checked for keyboard-only and screenreader accessibility~~
~~[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser~~
~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-02-07T11:12:36Z

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

elasticmachine · 2020-02-07T12:04:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 17d04f1e8f0c8920ff998eb2aede1f369136551b

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls "before all" hook

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Advanced Settings
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: security feature controls
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook
[00:00:00]               │ info [empty_kibana] Loading "mappings.json"
[00:00:00]               │ info [empty_kibana] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_1/VXVWVp4BSnq0GdnOaAX_YQ] deleting index
[00:00:00]               │ info [empty_kibana] Deleted existing index [".kibana_1"]
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:00]               │ info [empty_kibana] Created index ".kibana"
[00:00:00]               │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:00]               │ info [empty_kibana] Indexed 2 docs into ".kibana"
[00:00:40]               │ proc [kibana]   log   [11:44:29.670] [warning][reporting] Generating a random key for xpack.reporting.encryptionKey. To prevent pending reports from failing on restart, please set xpack.reporting.encryptionKey in kibana.yml
[00:00:40]               │ proc [kibana] internal/process/warning.js:153
[00:00:40]               │ proc [kibana]         throw warning;
[00:00:40]               │ proc [kibana]         ^
[00:00:40]               │ proc [kibana] 
[00:00:40]               │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:00:40]               │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:00:40]               │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:00:40]               │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:00:40]               │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:00:40]               └- ✖ fail: "Advanced Settings security feature controls "before all" hook"
[00:00:40]               │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34) name: 'DeprecationWarning', code: 'DEP0018', uncaught: true }

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls "after all" hook in "security feature controls"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Advanced Settings
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: security feature controls
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook
[00:00:00]               │ info [empty_kibana] Loading "mappings.json"
[00:00:00]               │ info [empty_kibana] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_1/VXVWVp4BSnq0GdnOaAX_YQ] deleting index
[00:00:00]               │ info [empty_kibana] Deleted existing index [".kibana_1"]
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:00]               │ info [empty_kibana] Created index ".kibana"
[00:00:00]               │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:00]               │ info [empty_kibana] Indexed 2 docs into ".kibana"
[00:00:40]               │ proc [kibana]   log   [11:44:29.670] [warning][reporting] Generating a random key for xpack.reporting.encryptionKey. To prevent pending reports from failing on restart, please set xpack.reporting.encryptionKey in kibana.yml
[00:00:40]               │ proc [kibana] internal/process/warning.js:153
[00:00:40]               │ proc [kibana]         throw warning;
[00:00:40]               │ proc [kibana]         ^
[00:00:40]               │ proc [kibana] 
[00:00:40]               │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:00:40]               │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:00:40]               │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:00:40]               │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:00:40]               │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:00:40]               └- ✖ fail: "Advanced Settings security feature controls "before all" hook"
[00:00:40]               │
[00:00:40]               └-> "after all" hook
[00:00:42]                 │ERROR [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=1/5)
[00:00:43]                 │ info Creating index .kibana_2.
[00:00:43]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:43]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:43]                 │ info Reindexing .kibana to .kibana_1
[00:00:43]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:43]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:43]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:43]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] updating number_of_replicas to [0] for indices [.tasks]
[00:00:43]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] 574 finished with response BulkByScrollResponse[took=52.9ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:43]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana/veOPJoT1SUmKi8AvtxPHrQ] deleting index
[00:00:43]                 │ info Migrating .kibana_1 saved objects to .kibana_2
[00:00:43]                 │ debg Migrating saved objects config:6.0.0-alpha1, space:default
[00:00:43]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_2/M_HfQSbeRwWelyMvddm2EA] update_mapping [_doc]
[00:00:43]                 │ERROR [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=2/5)
[00:00:43]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581074022536679471] [.kibana_2/M_HfQSbeRwWelyMvddm2EA] update_mapping [_doc]
[00:00:43]                 │ info Pointing alias .kibana to .kibana_2.
[00:00:43]                 │ info Finished in 793ms.
[00:00:43]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:43]                 │ERROR [POST http://elastic:changeme@localhost:6131/api/kibana/settings] request failed (attempt=1/5)
[00:00:44]                 │ERROR [POST http://elastic:changeme@localhost:6131/api/kibana/settings] request failed (attempt=2/5)
[00:00:45]                 │ERROR [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=3/5)
[00:00:46]                 │ERROR [POST http://elastic:changeme@localhost:6131/api/kibana/settings] request failed (attempt=3/5)
[00:00:48]                 │ERROR [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=4/5)
[00:00:49]                 │ERROR [POST http://elastic:changeme@localhost:6131/api/kibana/settings] request failed (attempt=4/5)
[00:00:52]                 │ERROR [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=5/5)
[00:00:52]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Advanced Settings security feature controls _after all_ hook.png"
[00:00:53]                 │ info Current URL is: data:/,
[00:00:53]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Advanced Settings security feature controls _after all_ hook.html
[00:00:53]                 └- ✖ fail: "Advanced Settings security feature controls "after all" hook in "security feature controls""
[00:00:53]                 │

Stack Trace

Error: [GET http://elastic:changeme@localhost:6131/api/status] request failed (attempt=5/5) -- and ran out of retries
    at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode "before all" hook: initialize tests

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: dashboard mode
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: Dashboard View Mode
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook: initialize tests
[00:00:00]               │ debg Dashboard View Mode:initTests
[00:00:00]               │ proc [kibana] internal/process/warning.js:153
[00:00:00]               │ proc [kibana]         throw warning;
[00:00:00]               │ proc [kibana]         ^
[00:00:00]               │ proc [kibana] 
[00:00:00]               │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:00:00]               │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:00:00]               │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:00:00]               │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:00:00]               │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:00:00]               │ERROR [GET http://elastic:changeme@localhost:6181/api/status] request failed (attempt=1/5)
[00:00:00]               └- ✖ fail: "dashboard mode Dashboard View Mode "before all" hook: initialize tests"
[00:00:00]               │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34) name: 'DeprecationWarning', code: 'DEP0018', uncaught: true }

and 51 more failures, only showing the first 3.

History

💔 Build #24513 failed fbc9163b48da5dcdda11ee92c7ee35d3fa82b1e3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan · 2020-02-13T02:14:06Z

x-pack/legacy/plugins/reporting/export_types/common/execute_job/get_custom_logo.ts

  };

-  const savedObjects = server.savedObjects;
-  const savedObjectsClient = savedObjects.getScopedSavedObjectsClient(fakeRequest);
-  const uiSettings = server.uiSettingsServiceFactory({ savedObjectsClient });


Removed legacy dependency here

tsullivan · 2020-02-13T02:14:14Z

x-pack/legacy/plugins/reporting/export_types/csv/server/execute_job.ts

-    );
-    const uiConfig = server.uiSettingsServiceFactory({
-      savedObjectsClient,
-    });


Removed legacy dependency here

tsullivan · 2020-02-13T02:14:37Z

x-pack/legacy/plugins/reporting/server/legacy.ts

@@ -22,8 +22,6 @@ const buildLegacyDependencies = (
    xpack_main: server.plugins.xpack_main,
    reporting: reportingPlugin,
  },
-  savedObjects: server.savedObjects,
-  uiSettingsServiceFactory: server.uiSettingsServiceFactory,


Removed legacy dependencies here

tsullivan · 2020-02-13T02:16:57Z

...legacy/plugins/reporting/export_types/csv_from_savedobject/server/lib/generate_csv_search.ts

  server: ServerFacade,
  elasticsearch: ElasticsearchServiceSetup,
  logger: Logger,
  searchPanel: SearchPanel,
  jobParams: JobParamsDiscoverCsv
 ): Promise<CsvResultFromSearch> {
-  const { savedObjects, uiSettingsServiceFactory } = server;
-  const savedObjectsClient = savedObjects.getScopedSavedObjectsClient(
+  const savedObjectsClient = await reporting.getSavedObjectsClient(


Removed legacy dependency here and from line 76

tsullivan · 2020-02-13T02:18:38Z

x-pack/legacy/plugins/reporting/export_types/png/server/execute_job/index.ts

 ) {
+  const browserDriverFactory = await reporting.getBrowserDriverFactory();


We're also using other accessor methods to get internal dependencies that are available after setup, like this getBrowserDriverFactory and even getEsqueue

tsullivan · 2020-02-13T02:20:34Z

x-pack/legacy/plugins/reporting/server/lib/create_queue.ts

  server: ServerFacade,
  elasticsearch: ElasticsearchServiceSetup,
-  logger: Logger,
-  { exportTypesRegistry, browserDriverFactory }: CreateQueueFactoryOpts
-): Esqueue {


Since more accessors exist on the reporting object, I have simplified signatures like this because the extra opts no longer need to be passed separately

pgayvallet

The approach chosen to be able to pass dependencies only available during start to the route handlers that must be defined during setup definitely makes sense, and follows the suggested approach.

As explained in the comments:

I would still avoid passing the whole and concrete ReportingPlugin instance alongs the whole chain, and use a specialized type or at least interface for that
The plugin's start (and setup also it seems) method is currently returning an internal contract instead of a public (or empty) one. From what I see, these returns even seems unused as the calls in x-pack/legacy/plugins/reporting/server/legacy.ts are ignoring them, so I would remove that

pgayvallet · 2020-02-13T07:38:54Z

x-pack/legacy/plugins/reporting/server/lib/validate/index.ts

+    logger.error(err);
    logger.warning(


NIT: logging both an error and a warning?

pgayvallet · 2020-02-13T07:49:45Z

x-pack/legacy/plugins/reporting/server/plugin.ts

+      xpackMainPlugin.info.feature(PLUGIN_ID).registerLicenseCheckResultsGenerator(checkLicense);
+    });
+    // Reporting routes
+    registerRoutes(this, __LEGACY, plugins, this.logger);


For isolation and testability sake, I would really avoid using the concrete ReportingPlugin type for the registerRoutes (and every nested calls) signature, and use a specialized interface instead. Actually passing the plugin instance as the implementation is fine I think, but I would create a real fascade interface containing only the internally used methods, to at least excludes start and setup from the contract, something like Pick<ReportingPlugin, 'getEsqueue' | ...>

Another slight inprovement (imho) from this initial proposal would be to extract this contract you put in the ReportingPlugin class to another class and use it instead

Something like

const internalContract = new ReportingInternals(this.pluginStartDeps, this.exportTypesRegistry, [probably others]); registerRoutes(internalContract, __LEGACY, plugins, this.logger);

pgayvallet · 2020-02-13T08:04:57Z

x-pack/legacy/plugins/reporting/server/plugin.ts


-    // Reporting routes
-    registerRoutes(__LEGACY, plugins, exportTypesRegistry, browserDriverFactory, logger);
+    return this.pluginStartDeps;


This is supposed to be the plugin's public contract. You are currently returning an internal contract, which doesn't really make any sense of any plugins that may want to consume your API (even if I get that reporting is more of a 'end of chain' plugin, this still doesn't respect the core conventions)

this.pluginStartDeps = { savedObjects: core.savedObjects, uiSettings: core.uiSettings, esqueue, enqueueJob, };

My question is: I see you are using that internally (this.pluginStart$.next(this.pluginStartDeps);), but do you use anywhere this contract from the actual plugin's start return?

if no, I would stick to returning an empty contract ({})

If you do need to access this from outside of the shim for any reason, I would wrap it inside an __internal property to make it clear that this a temporary measure during migration

This follows my previous comment, I think your pluginStartDeps should be more named such as reportingInternalStartDeps or something like that, as it is supposed to be only consumed from inside your plugin.

It makes senses to use a new types for Internal* instead of hooking into the types that were conveniently there :). Since I chose to use a type conveniently in scope, that forced me to return it. I get the point that it should only public expose internals as-needed by outside consumers

if no, I would stick to returning an empty contract ({})

👍

pgayvallet · 2020-02-13T08:08:32Z

x-pack/legacy/plugins/reporting/export_types/csv/server/execute_job.ts

->> = function executeJobFactoryFn(
+>> = async function executeJobFactoryFn(
+  reporting: ReportingPlugin,
  server: ServerFacade,
  elasticsearch: ElasticsearchServiceSetup,
  parentLogger: Logger


Minor: now that you introduced this ReportingPlugin internal that currently contains SO accessors such as reporting.getSavedObjectsClient(fakeRequest), it would probably makes sense to move the elasticsearch accessors inside it too instead of passing it as an additional parameter, for consistency.

the thought occurred to me as well, so 👍

I'd like to take this on in a future PR. It would make sense to get this in before working on the migration of our "config" usage on the server. Config can also follow the pattern of using an accessor on the reporting object.

fine with me

pgayvallet

LGTM for platform changes

tsullivan · 2020-02-14T16:56:56Z

@elasticmachine merge upstream

kibanamachine · 2020-02-14T18:33:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e78d4b5

History

💔 Build #26729 failed 7468889
💔 Build #26687 failed 1c6a6b0
💚 Build #26391 succeeded dd0fd40
💔 Build #26357 failed c391413a994c2ae71ba4754e9f78b8d82024ae8a
💛 Build #26337 was flaky 25dc761

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…cies (elastic#56824) * [Reporting/New Platform] Provide async access to server-side * consistent name for reportingPlugin * Prettier changes * simplify reporting usage collector setup * add more tests * extract internals access to separate core class * fix tests * fix imports for jest and build Co-authored-by: Elastic Machine <[email protected]>

…pendencies (#56824) (#57727) * [Reporting/New Platform] Provide async access to server-side dependencies (#56824) * [Reporting/New Platform] Provide async access to server-side * consistent name for reportingPlugin * Prettier changes * simplify reporting usage collector setup * add more tests * extract internals access to separate core class * fix tests * fix imports for jest and build Co-authored-by: Elastic Machine <[email protected]> * fix lint * fix ts import Co-authored-by: Elastic Machine <[email protected]>

tsullivan force-pushed the reporting/np-server-uisettings branch from fbc9163 to 17d04f1 Compare February 7, 2020 05:08

streamich added the Team:Reporting Services label Feb 7, 2020

elastic deleted a comment from kibanamachine Feb 7, 2020

tsullivan force-pushed the reporting/np-server-uisettings branch 2 times, most recently from 5e89c52 to 073cbcf Compare February 11, 2020 21:48

tsullivan added Feature:NP Migration (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v7.7.0 v8.0.0 labels Feb 12, 2020

tsullivan requested review from joelgriffith, bmcconaghy and a team February 12, 2020 19:48

tsullivan marked this pull request as ready for review February 12, 2020 20:25

tsullivan changed the title ~~[Reporting/New Platform] Async access for cross-plugin server-side dependencies~~ [Reporting/New Platform] Provide async access to server-side dependencies Feb 12, 2020

tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Feb 12, 2020

tsullivan force-pushed the reporting/np-server-uisettings branch from 9d57ada to 807be16 Compare February 12, 2020 20:34

tsullivan added 3 commits February 12, 2020 14:02

[Reporting/New Platform] Provide async access to server-side

e8ddc7b

Prettier changes

d235b16

consistent name for reportingPlugin

e8aa02d

tsullivan force-pushed the reporting/np-server-uisettings branch from 807be16 to 1a9e839 Compare February 12, 2020 21:18

simplify reporting usage collector setup

25dc761

tsullivan force-pushed the reporting/np-server-uisettings branch from 1a9e839 to 25dc761 Compare February 12, 2020 21:20

add more tests

dd0fd40

tsullivan force-pushed the reporting/np-server-uisettings branch from c391413 to dd0fd40 Compare February 13, 2020 00:32

tsullivan commented Feb 13, 2020

View reviewed changes

tsullivan requested a review from rudolf February 13, 2020 02:20

pgayvallet reviewed Feb 13, 2020

View reviewed changes

tsullivan added 6 commits February 13, 2020 09:57

Merge branch 'master' into reporting/np-server-uisettings

2f12495

extract internals access to separate core class

facd94b

Merge branch 'master' into reporting/np-server-uisettings

a3afefd

fix tests

1c6a6b0

Merge branch 'master' into reporting/np-server-uisettings

47cb1fd

fix imports for jest and build

7468889

pgayvallet approved these changes Feb 14, 2020

View reviewed changes

Merge branch 'master' into reporting/np-server-uisettings

e78d4b5

tsullivan merged commit 34ae99b into elastic:master Feb 14, 2020

tsullivan deleted the reporting/np-server-uisettings branch February 14, 2020 19:36

tsullivan mentioned this pull request Feb 14, 2020

[7.x] [Reporting/New Platform] Provide async access to server-side dependencies (#56824) #57727

Merged

tsullivan mentioned this pull request Feb 24, 2020

[Reporting] New Platform Migration #53898

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reporting/New Platform] Provide async access to server-side dependencies #56824

[Reporting/New Platform] Provide async access to server-side dependencies #56824

tsullivan commented Feb 5, 2020 •

edited

Loading

elasticmachine commented Feb 7, 2020

elasticmachine commented Feb 7, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

tsullivan Feb 13, 2020

tsullivan Feb 13, 2020

tsullivan Feb 13, 2020

tsullivan Feb 13, 2020 •

edited

Loading

tsullivan Feb 13, 2020

tsullivan Feb 13, 2020

pgayvallet left a comment

pgayvallet Feb 13, 2020

pgayvallet Feb 13, 2020

pgayvallet Feb 13, 2020

tsullivan Feb 13, 2020

pgayvallet Feb 13, 2020

tsullivan Feb 13, 2020

tsullivan Feb 14, 2020

pgayvallet Feb 14, 2020

pgayvallet left a comment

tsullivan commented Feb 14, 2020

kibanamachine commented Feb 14, 2020

		) {
		const browserDriverFactory = await reporting.getBrowserDriverFactory();

[Reporting/New Platform] Provide async access to server-side dependencies #56824

[Reporting/New Platform] Provide async access to server-side dependencies #56824

Conversation

tsullivan commented Feb 5, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Feb 7, 2020

elasticmachine commented Feb 7, 2020

💔 Build Failed

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsullivan Feb 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

tsullivan commented Feb 14, 2020

kibanamachine commented Feb 14, 2020

💚 Build Succeeded

History

tsullivan commented Feb 5, 2020 •

edited

Loading

tsullivan Feb 13, 2020 •

edited

Loading