Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting/fix listing pagination #62881

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 7, 2020

Summary

Closes #62874

#17926 added the ability to delete reports for 7.7. Unfortunately by replacing the EuiBasicTable with EuiInMemory table, a huge bug was introduced where pagination stopped working correctly.

Reporting fetches each page of jobs separately to reduce the response payload for rendering the table. EuiInMemoryTable expects that all the data is present in memory at the same time, and it allows paging (and enables search) through that.

This PR reverts the switch, and goes back to EuiBasicTable. Because of that, there is no "toolbar" available at the top of the table. The Delete button is moved to below the table, so that it doesn't cause layout shifting as hit appears / disappears. Also, search can not be supported at this time.

Screenshots:

BEFORE (showing the pagination bug)
2020-04-07 16 17 55

AFTER (new type of table)
2020-04-07 16 16 53

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, might be something we have to come back to and fix if they're 20 pages deep in reports, and delete something halfway-through

@tsullivan tsullivan merged commit 8d8c411 into elastic:master Apr 8, 2020
@tsullivan tsullivan deleted the reporting/fix-listing-pagination branch April 8, 2020 16:24
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 8, 2020
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 8, 2020
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
tsullivan added a commit that referenced this pull request Apr 8, 2020
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
tsullivan added a commit that referenced this pull request Apr 8, 2020
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana doesn't display more than 10 reports
5 participants