-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Improve functional test steps #63259
Conversation
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
e3b81b0
to
2d45a68
Compare
log.debug('ReportingPage:initTests'); | ||
await PageObjects.settings.navigateTo(); | ||
await esArchiver.loadIfNeeded('../../functional/es_archives/logstash_functional'); | ||
await esArchiver.load('reporting/historic'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reporting/historic
was not used for anything
await esArchiver.load('reporting/historic'); | ||
await kibanaServer.uiSettings.replace({ | ||
defaultIndex: 'logstash-*', | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A default index is provided by the ES Archive now
2d45a68
to
1c553ac
Compare
I've added the 7.7.0 version label, as all of these tests are still being skipped in the 7.7 branch and we'd like to re-enable them. cc @liza-mae |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I started flaky test runner with 30 threads to check if it is stable:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/361/
Let's wait for it before merge
* Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <[email protected]>
* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...
* Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <[email protected]>
* Revert "FTR: add chromium-based Edge browser support (#61684) (#63068)" This reverts commit e8caa06. * update lock file * [Reporting] Improve functional test steps (#63259) * Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <[email protected]> * get tests to pass * get more tests to pass * reduce branch diffs * reduce loc change Co-authored-by: Dzmitry Lemechko <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* resolve conflicts * get tests to pass * get more tests to pass * reduce branch diffs Co-authored-by: Elastic Machine <[email protected]>
Summary
This PR streamlines Reporting functional tests by using ES-Archiver to load saved dashboards to report against, instead of building a dashboard on-the-fly in the test.
Timing results:
BEFORE
AFTER
NOTE:
x-pack/test/reporting/functional/reports/baseline
were not used, so I removed them in this PR.