"View raw data" action #63710
Closed
"View raw data" action #63710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer can filter on a visualizationStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer can filter on a visualizationStandard OutStack TraceKibana Pipeline / kibana-intake-agent / Jest Integration Tests.src/core/server/http/integration_tests.http service elasticsearch passes request authorization header to Elasticsearch if registerAuth was not setStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
streamich
commented
May 1, 2020
| const queryState: QueryState = {}; | ||
|
|
||
| if (timeRange) queryState.time = timeRange; | ||
| if (refreshInterval) queryState.filters = filters?.filter(f => esFilters.isFilterPinned(f)); |
There was a problem hiding this comment.
Should be filters 😱
streamich
commented
May 1, 2020
Comment on lines
+137
to
+165
| let { timeRange, query, filters } = embeddable.getInput(); | ||
| const indexPatternId = this.getIndexPattern(embeddable); | ||
| let filtersFromEvent = await (async () => { | ||
| try { | ||
| if (isRangeSelectTriggerContext(context)) | ||
| return await createFiltersFromRangeSelectAction(context.data); | ||
| if (isValueClickTriggerContext(context)) | ||
| return await createFiltersFromValueClickAction(context.data); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| ` | ||
| DashboardToDashboard drilldown: can't extract filters from action. | ||
| Is it not supported action?`, | ||
| context | ||
| ); | ||
|
|
||
| return []; | ||
| } catch (e) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| ` | ||
| DashboardToDashboard drilldown: error extracting filters from action. | ||
| Continuing without applying filters from event`, | ||
| e | ||
| ); | ||
| return []; | ||
| } | ||
| })(); |
There was a problem hiding this comment.
This block is used in many places, maybe put it in a function.
|
Hey, I played with the PR a bit, |
|
@AlonaNadler I like "View raw data", also could be "View documents" or "View raw documents". I used here "View in Discover" because "View raw logs" felt incorrect, and @alexh97 had the same feelings. To make it work in TSVB somebody needs to be assigned to #60611 And to make it work in Lens, somebody needs to implement what Tim describes in this comment #62214 (comment) Also would be nice to do the same for Timelion #60613 BTW, if those issues are implemented, not only "View raw data" action will work with those visualizations, but also drilldowns. |
|
@alex-fedotyev following our slack conversation "unguided troubleshooting/analysis workflow for APM, the easiest way to explain it would be to imagine combining together Lens + Discover together." checkout this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #62652
Checklist
Delete any items that are not applicable to this PR.
For maintainers