[Reporting] Remove boilerplate needed to get thegetScreenshots function
#64269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
Apr 22, 2020
| const generatePngObservable = generatePngObservableFactory( | ||
| captureConfig, | ||
| mockBrowserDriverFactory | ||
| ); |
There was a problem hiding this comment.
lots of boilerplate getting simplified :)
tsullivan
force-pushed
the
reporting/add-plugin-contract
branch
from
6defc0f
to
3e4e482
Compare
tsullivan
changed the title
getScreenshots getScreenshots function
tsullivan
added
v7.8
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream |
poffdeluxe
approved these changes
Apr 27, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 27, 2020
…tion (elastic#64269) * expose reportingCore in ReportingSetup for apps * improve tests Co-authored-by: Elastic Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Apr 27, 2020
…tion (#64269) (#64591) * expose reportingCore in ReportingSetup for apps * improve tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the boilerplate needed for gaining a handle to the screenshot capture function. This is groundwork for moving the Reporting queue to Task Manager and ditching ESQueue.
This PR begins work on a future goal to allow outside plugins to generate their screenshots using the Reporting plugin pipeline. Once the Reporting code is fully migrated to the New Platform, exposing our screenshot capture function in the plugin contract would just be to change the
ReportingSetupinterface:...and return an object with that function from
ReportingPlugin#start. Then an outside plugin could addreportingas a dependency in thekibana.jsonand would get theReportingSetupobject in their plugin's start function.The first use case of using
reportingas a dependency should be to build a performance-measuring tool that helps the developers make incremental improvements to make reports run faster. See a draft plugin at: https://github.com/tsullivan/awesome_reporting_tools and the integration code at https://github.com/tsullivan/awesome_reporting_tools (depends on changes that are not in this PR).Checklist
Delete any items that are not applicable to this PR.
For maintainers