-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Remove boilerplate needed to get thegetScreenshots
function
#64269
[Reporting] Remove boilerplate needed to get thegetScreenshots
function
#64269
Conversation
const generatePngObservable = generatePngObservableFactory( | ||
captureConfig, | ||
mockBrowserDriverFactory | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of boilerplate getting simplified :)
6defc0f
to
3e4e482
Compare
getScreenshots
getScreenshots
function
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This is super clean!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…tion (elastic#64269) * expose reportingCore in ReportingSetup for apps * improve tests Co-authored-by: Elastic Machine <[email protected]>
…tion (#64269) (#64591) * expose reportingCore in ReportingSetup for apps * improve tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
This PR removes the boilerplate needed for gaining a handle to the screenshot capture function. This is groundwork for moving the Reporting queue to Task Manager and ditching ESQueue.
This PR begins work on a future goal to allow outside plugins to generate their screenshots using the Reporting plugin pipeline. Once the Reporting code is fully migrated to the New Platform, exposing our screenshot capture function in the plugin contract would just be to change the
ReportingSetup
interface:...and return an object with that function from
ReportingPlugin#start
. Then an outside plugin could addreporting
as a dependency in thekibana.json
and would get theReportingSetup
object in their plugin's start function.The first use case of using
reporting
as a dependency should be to build a performance-measuring tool that helps the developers make incremental improvements to make reports run faster. See a draft plugin at: https://github.com/tsullivan/awesome_reporting_tools and the integration code at https://github.com/tsullivan/awesome_reporting_tools (depends on changes that are not in this PR).Checklist
Delete any items that are not applicable to this PR.
For maintainers