[Reporting] Migrate server-side usage collector #67233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/migrate-usage-collector
branch
from
be8c4a3
to
c2f8aa4
Compare
19 tasks
tsullivan
commented
May 26, 2020
| const getLicense = async () => { | ||
| return await licensing.license$ | ||
| .pipe( | ||
| map(({ isAvailable, type }) => ({ |
There was a problem hiding this comment.
The FeaturesAvailable type being implemented here carries over the shape of the data from the Legacy xpack_main. This is done to avoid needing extra changes for underlying code.
tsullivan
changed the title
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
added
the
release_note:skip
|
@elasticmachine merge upstream |
|
(jenkins upgrade required killing all jobs) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 27, 2020
* [Reporting] Migrate server/usage * fix import * polish * prefer inferring return type Co-authored-by: Elastic Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
May 27, 2020
* [Reporting] Migrate server/usage * fix import * polish * prefer inferring return type Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
4 tasks
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of Reporting server-side migration from Legacy to Kibana Platform: #53898
This PR replaces a Legacy dependency called
xpack_mainfrom the Reporting usage collector and replaces it by getting license info from the Licensing plugin in Kibana Platform.Checklist
Delete any items that are not applicable to this PR.
For maintainers