[Reporting/Download CSV] Get the file name from savedSearch data #76031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en in the dashboard
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 27, 2020
…stic#76031) * [Reporting/Download CSV] provide title even if panel \titles are hidden in the dashboard * add functional test * Update embeddable_panel.tsx * Update download_csv.ts
tsullivan
added a commit
that referenced
this pull request
Aug 28, 2020
) (#76104) * [Reporting/Download CSV] provide title even if panel \titles are hidden in the dashboard * add functional test * Update embeddable_panel.tsx * Update download_csv.ts
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #75456
The function used for getting the panel title was returning an empty string when the Dashboard was configured to hide the panel titles. This PR changes which function is called to get the title of the saved search that is used as the downloaded file name.
Release note: fix a bug where the downloading CSV from a saved search in a dashboard panel had no file name if the dashboard panels were hidden.
Checklist
Delete any items that are not applicable to this PR.
For maintainers