Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Add functional test for Reports in non-default spaces #76053

Merged
merged 10 commits into from
Sep 1, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Aug 26, 2020

Summary

Closes #72875

This PR adds an API integration test to ensure that if saved objects are within a non-default space, exporting via the job generation API will still work.

  • CSV Export
  • PDF
  • PNG

@tsullivan tsullivan force-pushed the fix/72875 branch 2 times, most recently from e4d7969 to 5f35de7 Compare August 26, 2020 23:42
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@@ -21,7 +21,7 @@ export default function ({ getService }: FtrProviderContext) {
const reportingAPI = getService('reportingAPI');
const usageAPI = getService('usageAPI');

describe('reporting usage', () => {
describe('Usage', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full name of the test was Reporting reporting Usage and this changes it to Reporting Usage

@@ -20,7 +20,7 @@ export default function ({ getService }: FtrProviderContext) {
* The Reporting API Functional Test config implements a network policy that
* is designed to disallow the following Canvas worksheet
*/
describe('reporting network policy', () => {
describe('Network Policy', () => {
Copy link
Member Author

@tsullivan tsullivan Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of an external describe that wrap an import of this file, the name of the test was Reporting reporting Network Policy and removes the repetition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good to know

@tsullivan
Copy link
Member Author

This was acting flaky in my local environment last week, but it seems better this week(?)

@tsullivan tsullivan marked this pull request as ready for review August 31, 2020 17:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan changed the title [Reporting] Add functional test for Download CSV in non-default space [Reporting] Add functional test for Reports in non-default spaces Aug 31, 2020
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LGTM! Happy to have a spaces PR

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit a3af33d into elastic:master Sep 1, 2020
@tsullivan tsullivan deleted the fix/72875 branch September 1, 2020 23:55
tsullivan added a commit to tsullivan/kibana that referenced this pull request Sep 2, 2020
…astic#76053)

* [Reporting] Add functional test for Download CSV in non-default space

* skip tests

* unskip

* rm comment

Co-authored-by: Elastic Machine <[email protected]>
tsullivan added a commit that referenced this pull request Sep 2, 2020
…6053) (#76462)

* [Reporting] Add functional test for Download CSV in non-default space

* skip tests

* unskip

* rm comment

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 2, 2020
* master: (223 commits)
  skip flaky suite (elastic#75724)
  [Reporting] Add functional test for Reports in non-default spaces (elastic#76053)
  [Enterprise Search] Fix various icons in dark mode (elastic#76430)
  skip flaky suite (elastic#76245)
  Add `auto` interval to histogram AggConfig (elastic#76001)
  [Resolver] generator uses setup_node_env (elastic#76422)
  [Ingest Manager] Support both zip & tar archives from Registry (elastic#76197)
  [Ingest Manager] Improve agent vs kibana version checks (elastic#76238)
  Manually building `KueryNode` for Fleet's routes (elastic#75693)
  remove dupe tinymath section (elastic#76093)
  Create APM issue template (elastic#76362)
  Delete unused file. (elastic#76386)
  [SECURITY_SOLUTION][ENDPOINT] Trusted Apps Create API (elastic#76178)
  [Detections Engine] Add Alert actions to the Timeline (elastic#73228)
  [Dashboard First] Library Notification (elastic#76122)
  [Maps] Add mvt support for ES doc sources  (elastic#75698)
  Add setHeaderActionMenu API to AppMountParameters (elastic#75422)
  [ML] Remove "Are you sure" from data frame analytics jobs (elastic#76214)
  [yarn] remove typings-tester, use @ts-expect-error (elastic#76341)
  [Reporting/CSV] Do not fail the job if scroll ID can not be cleared (elastic#76014)
  ...
myasonik pushed a commit to myasonik/kibana that referenced this pull request Sep 2, 2020
…astic#76053)

* [Reporting] Add functional test for Download CSV in non-default space

* skip tests

* unskip

* rm comment

Co-authored-by: Elastic Machine <[email protected]>
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Expand testing for non-default space report generation
5 participants