Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Adds Dashboard Maps by value functional tests #90449

Merged
merged 6 commits into from
Feb 11, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Feb 5, 2021

Adds functional tests for Dashboard Maps by value, a part of #80584.

Tests include adding a map to a dashboard by value. Editing a by value map. Editing a by value map and saving to your library.

@crob611 crob611 added Feature:Dashboard Dashboard related features loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0 v8.0.0 labels Feb 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test additions, LGTM!

@crob611
Copy link
Contributor Author

crob611 commented Feb 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 11, 2021
@crob611 crob611 merged commit 609b5bf into elastic:master Feb 11, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2021
)

* Adds Dashboard Maps by value functional tests

* Fix license header issue

* License check

* Fix duplicate import

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Feature:Dashboard","Team:Presentation","auto-backport","loe:days","release_note:skip","review","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"609b5bf1b748cb573526050c45404b399ab3df81\",\"formattedMessage\":\"[Dashboard] Adds Dashboard Maps by value functional tests (#90449)\",\"originalMessage\":\"[Dashboard] Adds Dashboard Maps by value functional tests (#90449)\\n\\n* Adds Dashboard Maps by value functional tests\\r\\n\\r\\n* Fix license header issue\\r\\n\\r\\n* License check\\r\\n\\r\\n* Fix duplicate import\\r\\n\\r\\nCo-authored-by: Kibana Machine <[email protected]>\",\"pullNumber\":90449,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] [Dashboard] Adds Dashboard Maps by value functional tests (#90449)\". kibanamachine:backport/7.x/pr-90449 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1053ms"}
{"level":"info","message":"Adding assignees to #91183: crob611"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91183/assignees - 201 in 508ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91183/labels - 200 in 391ms"}
View pull request: https://github.com/elastic/kibana/pull/91183

crob611 pushed a commit that referenced this pull request Feb 12, 2021
…91183)

* Adds Dashboard Maps by value functional tests

* Fix license header issue

* License check

* Fix duplicate import

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Dashboard Dashboard related features loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants