-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Support Kibana deprecations #97159
Merged
alisonelizabeth
merged 25 commits into
elastic:master
from
alisonelizabeth:ua/kibana_deprecations
Apr 30, 2021
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8fe94fb
add support for kibana deprecations
alisonelizabeth 16ba626
design fixes
alisonelizabeth e68a6a0
fix build errors
alisonelizabeth 98a8c30
update overview tests
alisonelizabeth a0376ea
add tests for kibana deprecations
alisonelizabeth ac3d921
Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…
alisonelizabeth 413deba
Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…
alisonelizabeth 373f815
Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…
alisonelizabeth cbc289c
address design feedback
alisonelizabeth 9755153
support for auto resolving kibana deprecations
alisonelizabeth edbc2a4
add test for error condition
alisonelizabeth 480b6cd
TEMP commit: test Kibana API action
alisonelizabeth 68cff12
Revert "TEMP commit: test Kibana API action"
alisonelizabeth b6f83b6
update a11y tests and fix issue
alisonelizabeth 7a8291b
Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…
alisonelizabeth 9db7acf
Merge branch 'master' into ua/kibana_deprecations
kibanamachine 67bd309
add descriptions to telemetry
alisonelizabeth 0aa953e
update xpack_plugins.json
alisonelizabeth f3c9fe8
Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…
alisonelizabeth 0f227f9
address review feedback
alisonelizabeth 138cd07
remove unnecessary code comment
alisonelizabeth 52fe1fd
address review feedback
alisonelizabeth 5ebb45a
fix telemetry
alisonelizabeth 59412ce
update copy
alisonelizabeth 38c7e61
Merge branch 'master' into ua/kibana_deprecations
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 0 additions & 108 deletions
108
x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/controls.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe its worth allowing the user to change this number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great point. This was the behavior from the old implementation (for showing ES deprecations). I think I'd prefer to address this in a separate PR, but agree it would be better to not hard code this.