Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify snyk scanning #16475

Merged
merged 1 commit into from
Sep 25, 2024
Merged

simplify snyk scanning #16475

merged 1 commit into from
Sep 25, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Sep 25, 2024

  • remove docker image scanning as that's handled by infosec
  • run buildkite job on a docker image instead of vm (no need to test docker any more)

* remove docker image scanning as that's handled by infosec
* run buildkite job on a docker image instead of vm (no need to test docker any more)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jsvd
Copy link
Member Author

jsvd commented Sep 25, 2024

It looks like branch / version detection is not working correctly now for branch scanning since we added 8.x and main became 9.0.0.
This doesn't have to be fixed in this PR though. Follow up issue here: #16476

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jsvd jsvd merged commit 5c57ade into elastic:main Sep 25, 2024
6 checks passed
@jsvd jsvd deleted the remove_snyk_docker_scanning branch September 25, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants