set allow_superuser to false as default
#16558
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
commented
Oct 15, 2024
logstash-core/lib/logstash/runner.rb
Outdated
| deprecation_logger.deprecated("NOTICE: Running Logstash as superuser is not recommended and won't be allowed in the future. Set 'allow_superuser' to 'false' to avoid startup errors in future releases.") | ||
| deprecation_logger.deprecated("NOTICE: Running Logstash as superuser will be completely disallowed in future versions. " + | ||
| "To prepare for this and avoid startup errors in future releases, it is strongly recommended to set 'allow_superuser' to false now " + | ||
| "and adjust your configuration accordingly.") |
There was a problem hiding this comment.
copy from the companion pr
jsvd
reviewed
Oct 25, 2024
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Running as superuser is disabled by default. To continue running Logstash as superuser temporarily after the upgrade, set 'allow_superuser' to true.
What does this PR do?
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs