Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wolfi as base image #16599

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use wolfi as base image #16599

wants to merge 7 commits into from
+121 −325

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Oct 24, 2024 •
edited
Loading

Release notes

Logstash Docker images, full and OSS, now use Chainguard’s Wolfi image as its base, replacing the previous Ubuntu base.

What does this PR do?

  • change the base image to wolfi
  • use wolfi go image to build env2yaml
  • remove redundant and refactor steps
  • add support to build image in mac aarch64
  • allow customizing ELASTIC_VERSION and LOCAL_ARTIFACTS for test purpose
    • LOCAL_ARTIFACTS="false" BUILD_DATE="2024-10-23T18:09:57+01:00" DOCKER_ARCHITECTURE="aarch64" ELASTIC_VERSION="8.15.3" VERSION_TAG="8.15.3" ARTIFACTS_DIR="/path/to/logstash/build" make build-from-local-full-artifacts
    • It uses existing released tar.gz to build image which can skip the long local build proccess

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • build all images flavor and run them

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kaisecheng
- replace ubuntu base image to wolfi
969a918 
- use golang image to compile env2yaml
- refactor and reduce steps in Dockerfile
- support building image of custom version from remote tar.gz for test purpose
- add support to build image in MacOS
@kaisecheng
update docker tests
6c2e8c8
@kaisecheng
Copy link
Contributor Author

green in exhaustive test and dra

@kaisecheng kaisecheng marked this pull request as ready for review October 28, 2024 12:19
@kaisecheng kaisecheng requested a review from jsvd October 29, 2024 15:51
jsvd
jsvd requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in another medium, the goal is to provide, for 9.0.0:
-full and -oss images based on ubi, and a -wolfi image based on chainguard's base image.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status:work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaisecheng @elasticmachine @jsvd