Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 8.16.0 #16605

Open
wants to merge 6 commits into
base: 8.16
Choose a base branch
from
Open

Release notes for 8.16.0 #16605

wants to merge 6 commits into from
+78 −1

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

andsel
andsel reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple a couple of suggestions if you want to consider, with the driver to help users do informed on choices after reading this.

docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
jsvd
jsvd reviewed Oct 28, 2024
View reviewed changes
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
edmocosta and others added 2 commits October 28, 2024 15:40
@edmocosta edmocosta requested review from andsel and jsvd October 28, 2024 15:14
andsel
andsel requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minimal suggestion to be more specific on where is the "if conditionals"

docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
@edmocosta edmocosta requested a review from andsel October 28, 2024 15:20
andsel
andsel approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsvd
jsvd approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd marked this pull request as ready for review October 28, 2024 15:54
@karenzone karenzone mentioned this pull request Oct 30, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmocosta edmocosta edmocosta left review comments

@jsvd jsvd jsvd approved these changes

@andsel andsel andsel approved these changes

@karenzone karenzone Awaiting requested review from karenzone

Assignees

@robbavey robbavey

@edmocosta edmocosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsvd @andsel @edmocosta @robbavey @logstashmachine