Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Align CLI and config docs #3073

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

colleenmcginnis
Copy link
Contributor

Fixes #3030

Updates the Use the Synthetics CLI and Configure Synthetics projects docs to including:

  • Inventory the options in both and make sure all options line up.
  • Link between CLI and config docs.
  • Update the example config to match the latest config template.
    • Add a note that env is the environment users are pushing from not the environment where monitors will run.

cc @paulb-elastic

@colleenmcginnis colleenmcginnis added the backport-8.9 Automated backport with mergify label Jul 12, 2023
@colleenmcginnis colleenmcginnis self-assigned this Jul 12, 2023
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also add tags/alert as part of the monitor options? Release notes has some details on how its done - https://github.com/elastic/synthetics/releases

@colleenmcginnis
Copy link
Contributor Author

LGTM, can we also add tags/alert as part of the monitor options? Release notes has some details on how its done - https://github.com/elastic/synthetics/releases

Done in #3087.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review July 19, 2023 01:22
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner July 19, 2023 01:22
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-3030 upstream/issue-3030
git merge upstream/main
git push upstream issue-3030

Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great updates, thank you @colleenmcginnis, it really enhances the docs and shows the options available

LGTM

@colleenmcginnis colleenmcginnis removed the request for review from a team July 19, 2023 19:01
@colleenmcginnis colleenmcginnis merged commit 77ba6a8 into elastic:main Jul 19, 2023
1 check passed
@colleenmcginnis colleenmcginnis deleted the issue-3030 branch July 19, 2023 19:01
mergify bot pushed a commit that referenced this pull request Jul 19, 2023
* add info on timezones

* align cli and config docs

* locations don't get merged

* remove debug flag

* address feedback

(cherry picked from commit 77ba6a8)
colleenmcginnis added a commit that referenced this pull request Jul 19, 2023
* add info on timezones

* align cli and config docs

* locations don't get merged

* remove debug flag

* address feedback

(cherry picked from commit 77ba6a8)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document "project" settings in synthetics.config.ts
3 participants