Add a new section on how to collect any log from CloudWatch using Firehose #3887

alaudazzi · 2024-05-14T06:50:53Z

This PR:

Adds a new Firehose use case on Cloudwatch logs.
Reuses content drafted in Figure out how to collect any log from CloudWatch using Amazon Data Firehose zmoog/public-notes#86.

Closes #3882

github-actions · 2024-05-14T06:51:07Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

mergify · 2024-05-28T14:11:01Z

This pull request is now in conflict. Could you fix it @alaudazzi? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cloudwatch-firehose upstream/cloudwatch-firehose
git merge upstream/main
git push upstream cloudwatch-firehose

zmoog

I expanded steps 2-5 with the new content I added to the public note we used as a raw material source for this topic.

I think it is ready for a review round! 😇

dedemorton

Added some editorial contents. Some of the comments relate to restructuring. If you need help, you can reach out in the obs-docs channel in slack. Hope this is helpful!

docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudwatch-firehose.asciidoc

Co-authored-by: DeDe Morton <[email protected]>

zmoog · 2024-05-28T21:03:53Z

@dedemorton, thank you for your helpful review comments and suggestions!

I added all the suggestions and addressed the comments on the structure. Let me know what you think when you have time.

These diagrams help orient users in their journey.

bmorelli25

A couple more comments for ya!

docs/en/observability/cloud-monitoring/aws/monitor-aws-cloudwatch-firehose.asciidoc

alaudazzi · 2024-06-05T14:55:30Z

@bmorelli25 @dedemorton
Thank you for taking care of this PR during my PTO. Great review and useful suggestions!

@zmoog
I'm going to have another pass to harmonize structure and formatting.

alaudazzi · 2024-06-07T10:33:38Z

@zmoog
I had another pass to harmonize the structure and did some editing. Headings are still weird, I'm going to see how I can fix that.

alaudazzi · 2024-06-10T07:44:09Z

@zmoog This PR is ready to be merged. I fixed some headings and did a bit more editing.
Here is the latest doc preview. Let me know if this is OK for you.

zmoog

LGTM!

…ehose (#3887) * Start initial structure * Expand steps 2-5 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * Add progressing diagram to steps 2-5 These diagrams help orient users in their journey. * Integrate reviewer's feedback * Fix structure and wording * Fix structure and more editing --------- Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit ff69b83)

…ehose (#3887) (#3983) * Start initial structure * Expand steps 2-5 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * Add progressing diagram to steps 2-5 These diagrams help orient users in their journey. * Integrate reviewer's feedback * Fix structure and wording * Fix structure and more editing --------- Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit ff69b83) Co-authored-by: Arianna Laudazzi <[email protected]>

…ehose (#3887) (#3984) * Start initial structure * Expand steps 2-5 * Cleanup * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * Add progressing diagram to steps 2-5 These diagrams help orient users in their journey. * Integrate reviewer's feedback * Fix structure and wording * Fix structure and more editing --------- Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit ff69b83) Co-authored-by: Arianna Laudazzi <[email protected]>

Start initial structure

b8193ce

alaudazzi added docs Improvements or additions to documentation enhancement New feature or request backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify labels May 14, 2024

alaudazzi self-assigned this May 14, 2024

alaudazzi requested a review from zmoog May 14, 2024 06:51

Expand steps 2-5

f8dd023

zmoog and others added 2 commits May 28, 2024 18:15

Cleanup

632b9fb

Merge branch 'main' into cloudwatch-firehose

79b7f50

zmoog marked this pull request as ready for review May 28, 2024 16:19

zmoog requested a review from a team as a code owner May 28, 2024 16:19

zmoog requested a review from dedemorton May 28, 2024 16:19

zmoog reviewed May 28, 2024

View reviewed changes

dedemorton reviewed May 28, 2024

View reviewed changes

zmoog and others added 3 commits May 28, 2024 22:30

Apply suggestions from code review

65455e4

Co-authored-by: DeDe Morton <[email protected]>

Apply suggestions from code review

20d3f0b

Apply suggestions from code review

73661b0

Add progressing diagram to steps 2-5

fef51ce

These diagrams help orient users in their journey.

bmorelli25 reviewed May 30, 2024

View reviewed changes

Integrate reviewer's feedback

23dcd20

Fix structure and wording

ebb56dc

Fix structure and more editing

b88fc73

zmoog approved these changes Jun 10, 2024

View reviewed changes

mdbirnstiehl approved these changes Jun 10, 2024

View reviewed changes

alaudazzi merged commit ff69b83 into elastic:main Jun 10, 2024
3 checks passed

mergify bot mentioned this pull request Jun 10, 2024

[8.13](backport #3887) Add a new section on how to collect any log from CloudWatch using Firehose #3983

Merged

mergify bot mentioned this pull request Jun 10, 2024

[8.14](backport #3887) Add a new section on how to collect any log from CloudWatch using Firehose #3984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new section on how to collect any log from CloudWatch using Firehose #3887

Add a new section on how to collect any log from CloudWatch using Firehose #3887

alaudazzi commented May 14, 2024 •

edited by zmoog

Loading

github-actions bot commented May 14, 2024

mergify bot commented May 28, 2024

zmoog left a comment

dedemorton left a comment

zmoog commented May 28, 2024

bmorelli25 left a comment

alaudazzi commented Jun 5, 2024

alaudazzi commented Jun 7, 2024

alaudazzi commented Jun 10, 2024

zmoog left a comment

Add a new section on how to collect any log from CloudWatch using Firehose #3887

Add a new section on how to collect any log from CloudWatch using Firehose #3887

Conversation

alaudazzi commented May 14, 2024 • edited by zmoog Loading

github-actions bot commented May 14, 2024

mergify bot commented May 28, 2024

zmoog left a comment

Choose a reason for hiding this comment

dedemorton left a comment

Choose a reason for hiding this comment

zmoog commented May 28, 2024

bmorelli25 left a comment

Choose a reason for hiding this comment

alaudazzi commented Jun 5, 2024

alaudazzi commented Jun 7, 2024

alaudazzi commented Jun 10, 2024

zmoog left a comment

Choose a reason for hiding this comment

alaudazzi commented May 14, 2024 •

edited by zmoog

Loading