-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiling: add tips for kubernetes self-managed deployment #3932
Conversation
Signed-off-by: inge4pres <[email protected]>
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Francesco! I have a few recommendations for you.
|
||
2. Update the collector and symbolizer Helm values files to enable the use of TLS configuration: | ||
+ | ||
[source, yaml, highlight=3..4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this highlight
functionality doesn't work in our implementation of asciidoctor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bummer... is there anything else we can use to make the diff more evident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our docs support code callouts. You could add one of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a small text to clarify what needs to be done 👍🏼
Thanks for the hint 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
If you are using an ingress controller, the connection routing to the collector Service should be configured to use the gRPC protocol. | ||
|
||
We provide an `Ingress` resource as part of the Helm chart, and because the ingress can be any implementation, | ||
you should provide to the chart values the configuration of the ingress, adding the class name and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should provide to the chart values the configuration of the ingress
I'm not sure what you're trying to say here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ingress is managed by the chart, but its configurations need to be passed through from the users, as they are implementation-specific.
This practically means that all the times an ingress is enabled, it must be configured with some values passed in Helm by users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's very helpful. I made a small recommendation based off of this comment: https://github.com/elastic/observability-docs/pull/3932/files#r1621192289
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Signed-off-by: inge4pres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Reason for this PR
Closes https://github.com/elastic/prodfiler/issues/4586.
Details
Added tips to configure collector and symbolizer in k8s environments.
Specifically we're referencing secrets for output added in https://github.com/elastic/prodfiler/pull/4999