Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic elastic.co doc builds for internal users #3940

Merged
merged 2 commits into from
May 29, 2024

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 29, 2024

Summary

This PR removes the ci:doc-build label requirement for elastic.co doc builds. PRs opened by Elastic contributors will run this action automatically now. PRs opened by community members will need to have the action manually run.

To approve and run an action: Go to the Conversation tab, and under "Workflow(s) awaiting approval", click Approve and run.

@bmorelli25 bmorelli25 requested a review from a team as a code owner May 29, 2024 19:11
Copy link
Contributor

mergify bot commented May 29, 2024

This pull request does not have a backport label. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 29, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @elastic/docs-engineering any concerns?

@scottybollinger
Copy link
Contributor

Looks good to me. @elastic/docs-engineering any concerns?

None here. I echo your concerns raised elsewhere about implementing this in other repos we can't control, but this PR is fine.

@colleenmcginnis
Copy link
Contributor

@bmorelli25 can you add a description to this PR so we're not confused what it is later?

@bmorelli25
Copy link
Member Author

Done! Thank you both!

@bmorelli25 bmorelli25 merged commit 09f1e52 into main May 29, 2024
3 checks passed
@bmorelli25 bmorelli25 deleted the bmorelli25-patch-4 branch May 29, 2024 20:41
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request May 29, 2024
bmorelli25 added a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants