-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new IA for observability docs #4134
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good ✨
docs/en/observability/application-and-service-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
@dedemorton thank you for leading this doc refactoring!
Now to your questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great rework! I've left a few comments/suggestions.
@alaudazzi Thanks for your input! Just to clarify, I didn't go very far into the guts of each area because some of them (like APM) are going to need some extra special love. But I can certainly make the changes you want to the firehose section because it's pretty straightforward. :-) Thanks again. |
We made the following decisions during the team meeting today: For the getting started content:
For other tutorial-style content:
For troubleshooting topics, we will leave them as-is until a larger docs team plan emerges. |
The section that duplicates that content is Fleet-managed APM Server. As a part of https://github.com/elastic/obs-docs-projects/issues/260, I'm thinking we should change the section that contains that content from "Self manage APM Server" to "Get started" or "Set up". |
@alaudazzi Thanks for your input! Just an FYI--here's how I have addressed your feedback:
Nice idea. Done!
I'll look at this after the quickstarts are merged, but I think with the getting started section slimmed down, your suggestion makes sense.
It is. Already fixed based on Colleen's feedback.
Yay
Done
Let's wait and get more input from reviewers on this. I think we might get some mixed opinions about this. |
@colleenmcginnis So the page I need to link to does not have an ID. I'm going to add an ID that you can change later, if you want. |
@dedemorton I ran into similar errors recently...
... to fix them, you'll need to update the redirects in |
@colleenmcginnis @alaudazzi @bmorelli25 @mdbirnstiehl I'm curious what you think of merging the "get started" and quickstarts into one section: That way there is one page that has all the links to quickstarts and getting started. |
It makes sense, but I would remove "Quickstart" and reword the headings. It sounds weird to have a quickstart into a get started. How about this:
|
Why? In my mind, a quickstart is just a type of getting started document. I also think the quickstart label makes it clear that we're offering an accelerated path. I'm curious if other writers share your concern. I want to indicate in the nav somehow that these topics are special. |
This pull request is now in conflict. Could you fix it @dedemorton? 🙏
|
@dedemorton I'm curious what the distinction is between "get started" and "quickstart". What about the "Get started with data from Splunk" makes it not a quickstart? Could it be added to the "Get started" section as another quickstart? |
@colleenmcginnis @dedemorton Based on previous conversations we had at Elastic about content types and IA, I recall that it has always been hard to exactly define what is what. My understanding is that: A They are two different content types, they address two different audiences, so it would be more natural to have them at the same level. |
Interesting. Do you think Get started with data from Splunk is more general than Quickstart: Monitor your Kubernetes cluster with Elastic Agent? |
@colleenmcginnis Good question! Originally I had all the quickstarts under a "Quickstarts" section that explained what we mean by quickstarts (the term "quickstarts" does appear in the UI and I think the original issue requested that we describe what a quickstart is). Originally the titles of these quickstarts exactly matched the UI, but I was asked to make the title more goal oriented. The section that describes quickstarts is now here, but maybe it's too subtle and buried in the "Get started" topic? I mainly used "quickstart" in the topic titles to map this content to what users see in the UI and also let users know that the topic contains info to get started quickly. Edited: I forgot to mention splunk in my response. It's really an outlier because I can't more it into a different like I did with the other GS topics, but it really doesn't stand very well alone. Maybe I shouldn't even include "get started" in the title. WDYT? |
Met with other obs writers today. Decision was to:
|
@dedemorton - I think that universal profiling should be under infrastructure. IMO, we should have either'Get started' or 'Quick start' in the nav. Please let me know if you would like to me to review any other items. Thanks |
I've moved Universal Profiling to appear under the infra/hosts monitoring section. It didn't seem right to nest Universal Profiling under a topic that describes the Infrastructure UI, so I added a new container topic with a jump table to the subsections. That's the best I can do for the content as it is today. |
@akhileshpok Mainly I need you to confirm that the navigation/TOC structure looks good. With the new structure, we'll eventually need to add more content and rewrite some of the existing topics, but that work is out of scope for this PR. We'll backport this to 8.16, so the nav won't go live right away. That'll give other stakeholders an opportunity to suggest tweaks. Thanks! Adding the preview link to make it easier for you to see the final TOC: https://observability-docs_bk_4134.docs-preview.app.elstc.co/guide/en/observability/master/index.html |
I got the go-ahead from Akhilesh over slack. I just need to move the troubleshooting section, and I think we're ready to merge this into main. Akhilesh Pokhariyal
|
This pull request is now in conflict. Could you fix it @dedemorton? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes https://github.com/elastic/obs-docs-projects/issues/247
Preview link: https://observability-docs_bk_4134.docs-preview.app.elstc.co/guide/en/observability/master/index.html
Top-level TOC changes
Questions to consider during review
TODO
TODO after merging: