-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update infrastructure monitoring docs about containers #4186
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👏 thank you!
One note regarding the metrics - we also show Network
and Disk
now:
(Not sure if we want to include it in the screenshots - cc @roshan-elastic)
Overall LGTM but I am leaving the final review to @roshan-elastic
@jennypavlova Good point! I didn't see those tabs because I was looking at an environment that was all K8s. I think I should show those tabs. |
@jennypavlova or @roshan-elastic I have a few follow-up questions after applying the Jenny's changes:
|
Think I found something on edge:
Checking on the demo cluster (8.15), it doesn't look like it. Looks like 8.16 only.
Good catch. Added it now. One note - it looks like the @jennypavlova - Could you confirm if this is a bug? I know we're going to clean all of this up in https://github.com/elastic/observability-dev/issues/3470 |
This PR targets 8.15, so I am going to remove mention of network and disk metrics for now. I've opened a separate issue for 8.16 to make sure network and disk metrics get added when we're ready to document them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny suggestion.
docs/en/observability/monitor-infra/view-infrastructure-metrics.asciidoc
Outdated
Show resolved
Hide resolved
Fix containerd references. Co-authored-by: Colleen McGinnis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐥
* Update infrastructure monitoring docs about containers * Apply changes from review * Revert to 8.15 level info about container metrics * Apply suggestions from code review Fix containerd references. --------- Co-authored-by: Colleen McGinnis <[email protected]> (cherry picked from commit 38b0630)
* Update infrastructure monitoring docs about containers * Apply changes from review * Revert to 8.15 level info about container metrics * Apply suggestions from code review Fix containerd references. --------- Co-authored-by: Colleen McGinnis <[email protected]> (cherry picked from commit 38b0630) Co-authored-by: DeDe Morton <[email protected]>
Closes #3745
Preview links:
TODO after merging: