Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Document which fields are supported to create APM Service Groups #4198

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[APM] Document which fields are supported to create APM Service Groups #4198

merged 1 commit into from
Sep 20, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Aug 26, 2024 •
edited
Loading

Fixes #4023

Documents which fields are supported to create APM service groups and removes a note from the service groups doc.

To do

  • Dev/Product review
  • Writer review
  • Port to serverless?

cc @chrisdistasio @mielastic

@colleenmcginnis colleenmcginnis requested a review from a team as a code owner August 26, 2024 15:01
@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis self-assigned this Aug 26, 2024
@mergify Mergify

This comment was marked as outdated.

Sign in to view
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 26, 2024
@colleenmcginnis colleenmcginnis added backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Aug 26, 2024
@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@colleenmcginnis
Copy link
Contributor Author

👋 @smith is this something your team could take a look at?

smith
smith approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches what the code says, so looks good!

https://github.com/smith/kibana/blob/0ddbe0e5c7f9a8a677182860dfc26c231ff2e170/x-pack/plugins/observability_solution/apm/common/service_groups.ts#L34-L42

mdbirnstiehl
mdbirnstiehl approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@colleenmcginnis colleenmcginnis merged commit a64780f into elastic:main Sep 20, 2024
19 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-4023 branch September 20, 2024 19:13
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@colleenmcginnis @mergify
remove note, add list of dimensions (#4198)
0b4264f 
(cherry picked from commit a64780f)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
3 tasks
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@colleenmcginnis @mergify
remove note, add list of dimensions (#4198)
6a2afef 
(cherry picked from commit a64780f)
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@colleenmcginnis @mergify
remove note, add list of dimensions (#4198)
e777361 
(cherry picked from commit a64780f)
This was referenced Sep 20, 2024
Merged
Merged
@colleenmcginnis colleenmcginnis mentioned this pull request Sep 20, 2024
Merged
colleenmcginnis added a commit that referenced this pull request Sep 20, 2024
@mergify @colleenmcginnis
remove note, add list of dimensions (#4198) (#4286)
3d64949 
(cherry picked from commit a64780f)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Sep 20, 2024
@mergify @colleenmcginnis
remove note, add list of dimensions (#4198) (#4285)
8a1ca86 
(cherry picked from commit a64780f)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Sep 20, 2024
@mergify @colleenmcginnis
remove note, add list of dimensions (#4198) (#4284)
9252cac 
(cherry picked from commit a64780f)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@chrisdistasio chrisdistasio Awaiting requested review from chrisdistasio

@mielastic mielastic Awaiting requested review from mielastic

Assignees

@colleenmcginnis colleenmcginnis

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Document which fields are supported to create APM Service Groups
4 participants
@colleenmcginnis @smith @mdbirnstiehl @bmorelli25