Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all data set types to quality page #4232

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Add all data set types to quality page #4232

merged 10 commits into from
Oct 3, 2024

Conversation

mdbirnstiehl
Copy link
Contributor

This PR closes #4151.

The Data Set Quality page can now show data sets from metrics, traces, and synthetics in addition to logs.
I've update the page to show this and updated the screenshot.

@mdbirnstiehl mdbirnstiehl self-assigned this Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mdbirnstiehl mdbirnstiehl added the backport-skip Skip notification from the automated backport with mergify label Sep 9, 2024
mdbirnstiehl
mdbirnstiehl commented Sep 10, 2024
View reviewed changes
Copy link
Contributor Author

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yngrdyn will the steps to investigate ignored fields detailed here work for the other data set types at this point?

@yngrdyn
Copy link
Contributor

yngrdyn commented Sep 10, 2024

@yngrdyn will the steps to investigate ignored fields detailed here work for the other data set types at this point?

yes, It works mostly the same. The only thing is you won't be able to spot dataset quality issues from logs explorer for these other types. User will find the hints in discover.
And from the dataset quality page they will need to enable the new types using the type filter as per default it will only bring logs.

@elasticdocs
Copy link

elasticdocs commented Sep 17, 2024 •
edited
Loading

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review September 17, 2024 16:46
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner September 17, 2024 16:46
@mdbirnstiehl
Copy link
Contributor Author

@yngrdyn could you take a look at this one?

yngrdyn
yngrdyn previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

colleenmcginnis
colleenmcginnis reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend for this to be a new top-level item in the Observability guide? (I'm not saying it shouldn't be because I don't know where else it would go, but I'm just checking!)

Screenshot 2024-09-25 at 9 47 51 AM

docs/en/observability/logs-monitor-datasets.asciidoc Outdated Show resolved Hide resolved
@mdbirnstiehl
Copy link
Contributor Author

Did you intend for this to be a new top-level item in the Observability guide? (I'm not saying it shouldn't be because I don't know where else it would go, but I'm just checking!)

Screenshot 2024-09-25 at 9 47 51 AM

I did, but I also meant to ask @dedemorton for any suggestions she might have on this since it is the beautiful new IA, I don't want to muddy it up already.

colleenmcginnis
colleenmcginnis previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🐥

@bmorelli25
Copy link
Member

Should this go into 8.x?

@mdbirnstiehl mdbirnstiehl added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 2, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 2, 2024
colleenmcginnis
colleenmcginnis approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭 👍

@mdbirnstiehl mdbirnstiehl merged commit 442705e into elastic:main Oct 3, 2024
8 checks passed
@mdbirnstiehl mdbirnstiehl deleted the update-dataset-health branch October 3, 2024 15:26
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
@mdbirnstiehl @mergify
[Data set quality] Add all data set types to quality page (#4232)
7a93252 
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit 442705e)

# Conflicts:
#	docs/en/serverless/monitor-datasets.mdx
#	docs/en/serverless/serverless-observability.docnav.json
@mergify mergify bot mentioned this pull request Oct 3, 2024
Merged
mdbirnstiehl pushed a commit that referenced this pull request Oct 7, 2024
@mergify
[8.x](backport #4232) Add all data set types to quality page (#4344)
eff95f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

@yngrdyn yngrdyn yngrdyn left review comments

Assignees

@mdbirnstiehl mdbirnstiehl

Labels
backport-8.x Automated backport to the 8.x branch with mergify ci:doc-build needs-writer-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Opening page for other dataStream types
5 participants
@mdbirnstiehl @yngrdyn @elasticdocs @bmorelli25 @colleenmcginnis